-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[types removal] Logstash central management typeless API #30546
Merged
alexwizp
merged 4 commits into
elastic:master
from
jakelandis:logstash_central_config_remove_types
Mar 1, 2019
Merged
[types removal] Logstash central management typeless API #30546
alexwizp
merged 4 commits into
elastic:master
from
jakelandis:logstash_central_config_remove_types
Mar 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
4 tasks
💔 Build Failed |
💔 Build Failed |
retest |
💔 Build Failed |
retest |
💚 Build Succeeded |
mattapperson
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
alexwizp
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
@epixa Let's merge this PR with backport to 7.x and 7.0 |
💔 Build Failed |
retest |
💔 Build Failed |
retest |
💔 Build Failed |
alexwizp
changed the title
Logstash central management typeless API
[types removal] Logstash central management typeless API
Feb 28, 2019
💚 Build Succeeded |
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Mar 1, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Mar 1, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
alexwizp
added a commit
that referenced
this pull request
Mar 1, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
alexwizp
added a commit
that referenced
this pull request
Mar 4, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adopts Elasticsearch's typeless API for Logstash
central management.
Relates: elastic/elasticsearch#38637
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers