Add support for Lucene SuggestStopFilter #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we call this |
|
Was thinking if it might be usable in |
|
hmm maybe we do it totally different and make it an option on |
|
Updated to work as an additional option for the existing stopfilter, instead of being an own one. |
|
LGTM |
The suggest stop filter is an improved version of the stop filter, which takes stopwords only into account if the last char of a query is a whitespace. This allows you to keep stopwords, but to allow suggesting for "a". Example: Index document content "a word". You are now able to suggest for "a" and get back results in the completion suggester, if the suggest stop filter is used on the query side, but will not get back any results for "a " as this is identified as a stopword. The implementation allows to set the `remove_trailing` parameter for a custom stop filter and thus use the suggest stop filter instead of the standard stop filter.
jakelandis
added a commit
to jakelandis/kibana
that referenced
this pull request
Feb 8, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
7 tasks
jakelandis
added a commit
to jakelandis/logstash
that referenced
this pull request
Feb 8, 2019
This commit adopts Elasticsearch's typeless API for central management. Relates: elastic/elasticsearch#3863
alexwizp
pushed a commit
to elastic/kibana
that referenced
this pull request
Mar 1, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Mar 1, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Mar 1, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
alexwizp
added a commit
to elastic/kibana
that referenced
this pull request
Mar 1, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
alexwizp
added a commit
to elastic/kibana
that referenced
this pull request
Mar 4, 2019
This commit adopts Elasticsearch's typeless API for Logstash central management. Relates: elastic/elasticsearch#3863
jakelandis
added a commit
to jakelandis/logstash
that referenced
this pull request
Mar 6, 2019
This commit adopts Elasticsearch's typeless API for central management. Relates: elastic/elasticsearch#3863
elasticsearch-bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Mar 7, 2019
This commit adopts Elasticsearch's typeless API for central management. Relates: elastic/elasticsearch#3863 Fixes #10421
elasticsearch-bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Mar 7, 2019
This commit adopts Elasticsearch's typeless API for central management. Relates: elastic/elasticsearch#3863 Fixes #10421
elasticsearch-bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Mar 7, 2019
This commit adopts Elasticsearch's typeless API for central management. Relates: elastic/elasticsearch#3863 Fixes #10421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggest stop filter is an improved version of the stop filter, which
takes stopwords only into account if the last char of a query is a
whitespace. This allows you to keep stopwords, but to allow suggesting for
"a".
Example: Index document content "a word". You are now able to suggest for
"a" and get back results in the completion suggester, if the suggest stop
filter is used on the query side, but will not get back any results for
"a " as this is identified as a stopword.