[Logs UI] Fix pre-ECS filebeat module message reconstruction rules #30398
Conversation
weltenwort
added
WIP
|
Pinging @elastic/infrastructure-ui |
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
weltenwort
force-pushed
the
infra-ui-fix-pre-ecs-filebeat-messages
branch
2 times, most recently
from
d74f3f1 to
4359908
Compare
💚 Build Succeeded |
weltenwort
force-pushed
the
infra-ui-fix-pre-ecs-filebeat-messages
branch
from
4359908 to
2a93a2b
Compare
💔 Build Failed |
weltenwort
force-pushed
the
infra-ui-fix-pre-ecs-filebeat-messages
branch
from
2a93a2b to
a0e1bb3
Compare
💚 Build Succeeded |
weltenwort
added
review
[zube]: In Review
and removed
WIP
| @@ -4,6 +4,8 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import stringify from 'json-stable-stringify'; | |||
There was a problem hiding this comment.
We should probably use this in the Flyout code too.
There was a problem hiding this comment.
makes sense 👍 ➡️ #30930
I hope that was what you meant?
|
From a review standpoint I looked through everything and nothing stands out. What was your testing setup? Is a visual read through good enough? |
|
For manual testing I used the Given that there are unit tests for the new rules and that I included screenshots above, I would say checking for typos in the constant parts of the messages and consistency in the field selection would be most valuable. |
|
jenkins, test this |
💚 Build Succeeded |
|
@simianhacker is there anything else you need in order to perform the review? |
There was a problem hiding this comment.
I made another visual pass and everything looks good to me. I did load it in Kibana just to make sure nothing fatal happens.
__ ______ ______ __ __
/\ \ /\ ___\ /\__ _\ /\ "-./ \
\ \ \____ \ \ \__ \ \/_/\ \/ \ \ \-./\ \
\ \_____\ \ \_____\ \ \_\ \ \_\ \ \_\
\/_____/ \/_____/ \/_/ \/_/ \/_/
…lastic#30398) This fixes the message reconstruction for the pre-ECS formats of several filebeat modules by adding appropriate rules.
…lastic#30398) This fixes the message reconstruction for the pre-ECS formats of several filebeat modules by adding appropriate rules.
…lastic#30398) This fixes the message reconstruction for the pre-ECS formats of several filebeat modules by adding appropriate rules.
Summary
This fixes the message reconstruction for the pre-ECS formats of several filebeat modules by adding appropriate rules:
Notes on testing
The screenshot below have been created by ingesting the test data used by filebeat 6.7 itself.
Icinga
HAProxy
MongoDB
IIS
Logstash
Osquery
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately