-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Fix some filebeat ECS message formats #31120
Merged
weltenwort
merged 8 commits into
elastic:master
from
weltenwort:infra-ui-fix-ecs-filebeat-messages
Feb 21, 2019
Merged
[Logs UI] Fix some filebeat ECS message formats #31120
weltenwort
merged 8 commits into
elastic:master
from
weltenwort:infra-ui-fix-ecs-filebeat-messages
Feb 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
v7.0.0
[zube]: In Progress
Feature:Logs UI
Logs UI feature
v6.7.0
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
labels
Feb 14, 2019
Pinging @elastic/infrastructure-ui |
💚 Build Succeeded |
weltenwort
force-pushed
the
infra-ui-fix-ecs-filebeat-messages
branch
from
February 20, 2019 10:22
123c717
to
452eac2
Compare
💚 Build Succeeded |
weltenwort
added
review
[zube]: In Review
v8.0.0
v7.2.0
and removed
[zube]: In Progress
labels
Feb 20, 2019
simianhacker
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... I gave it a read through and nothing stands out to me. I also ran it in my browser with the data I have it seems to work. I didn't physically test every input listed but I'm pretty confident since the tests cover those.
This was referenced Feb 21, 2019
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Feb 21, 2019
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Feb 21, 2019
weltenwort
added a commit
that referenced
this pull request
Feb 21, 2019
weltenwort
added a commit
that referenced
this pull request
Feb 21, 2019
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Feb 22, 2019
weltenwort
added a commit
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Logs UI
Logs UI feature
release_note:fix
review
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v6.7.0
v7.0.0
v7.2.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the message reconstruction for the ECS formats of several filebeat modules by adding appropriate specific and generic rules. Fixed modules include:
In addition the generic log message fallbacks now try to make use of the standardized
event.dataset
andlog.severity
fields. The newlog.original
field has also been added as a fallback.The formats were developed to work with the filebeat 7.0.0 test sample files.
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately