Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix filter params in HTTP Access job custom URLs #30066

Merged
merged 1 commit into from
Feb 5, 2019
Merged

[ML] Fix filter params in HTTP Access job custom URLs #30066

merged 1 commit into from
Feb 5, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Feb 5, 2019 •
edited
Loading

Summary

Fixes the params section of the filters part of the custom URLs for the Apache and Nginx HTTP Access data recognizer modules, so that the filters can be opened for editing in the drilldown Kibana Dashboard or Discover. Follows on from work to add ECS versions of the modules in #29383.

Previously when clicking on the filter for editing in the Filters bar

image

the page could crash with an error Could not read property 'query' of undefined.

The meta property of the filters part of the _a part of each URL is now in the form:

params:(query:'nginx.access')

where before this params property was either missing or was in the form:

params:(query:'nginx.access'type:phrase)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@peteharverson peteharverson added review non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection labels Feb 5, 2019
@peteharverson peteharverson requested a review from a team as a code owner February 5, 2019 13:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jgowdyelastic
jgowdyelastic approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

walterra
walterra approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit d0f3b2a into elastic:master Feb 5, 2019
@peteharverson peteharverson deleted the ml-access-module-filter-params branch February 5, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes review v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87 @jgowdyelastic