Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Update http access modules for ECS #29383

Merged
merged 9 commits into from
Jan 31, 2019

Conversation

sophiec20
Copy link
Contributor

@sophiec20 sophiec20 commented Jan 25, 2019

Summary

Updates the fields used in the NGINX and Apache web access data recognizer modules to the Elastic Common Schema (ECS) field names.

The ECS modules also differ from the non-ECS versions by replacing the two drilldown dashboards (URL Explorer and Count Explorer) with a single HTTP Access Explorer dashboard for drilldown.

Summary of changes from non ECS versions:

  • Renamed following fields:

    • event.module:apache
    • event.dataset:access
    • source.address
    • url.original
    • http.response.status_code
    • source.geo.location
  • Only use one set of kibana saved objects for all http web access logs

  • Rename files from apache2 to apache

  • Combined URL explorer into Count explorer dashboard as there was a lot of duplication

  • Rename custom urls to Investigate Source IP and Status Code

  • Added chart to show overall event rate split by event.module - can tell if multiple datasets are included

  • Increased limit for top source ips from 5 to 50

  • Add created_by field for jobs

  • Rename jobs and saved objects to include ecs tag

Checklist

For maintainers

Rename following fields
event.module:apache
event.dataset:access
source.address
url.original
http.response.status_code
source.geo.location

Rationalise to only use one set of kibana saved objects for all http web access logs
Rename files from apache
Combined URL explorer into Count explorer dashboard as there was a lot of duplication
Add filter to custom url
Rename custom urls to Investigate Source IP and Status Code
Add chart to show overall event rate split by event.module - can tell if multiple datasets are included
Increase limit for top source ips from 5 to 50
Add created_by to custom setting for telemetry
Rename jobs and saved objects to include ecs tag

Tested side by side against v6 jobs
@sophiec20 sophiec20 added WIP Work in progress :ml Feature:Anomaly Detection ML anomaly detection labels Jan 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Rename http_status_code to status_code_rate
Update custom url to use filters instead of lucene query bar
Copy files, keeping nginx logo
Multiple renames to nginx
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sophiec20 sophiec20 added review and removed WIP Work in progress labels Jan 30, 2019
@sophiec20 sophiec20 changed the title [ML] Update apache module for ECS [ML] Update http access modules for ECS Jan 30, 2019
@sophiec20
Copy link
Contributor Author

This pr now contains nginx_ecs and apache_ecs modules and is ready for review. Data set is available for apache, nginx will be ready soon pending new build after elastic/beats#10418.

This pr does not yet remove the non-ecs modules. This will be a separate pr as these non-ecs modules may be useful for side-by-side comparisons.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May tweak some of the labels, but I will do this in a follow up PR

@peteharverson peteharverson merged commit 413d37d into elastic:master Jan 31, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants