[es] Fix ipv6 addresses used with angular connector

[jbudz]

When passing a host url to elasticsearch-js, it will use url.parse to pick fields ref.

url.parse().hostname does not include brackets in ipv6 addresses:

> url.parse('http://[::1]')
Url {
  protocol: 'http:',
  slashes: true,
  auth: null,
  host: '[::1]',
  port: null,
  hostname: '::1',
  hash: null,
  search: null,
  query: null,
  pathname: '/',
  path: '/',
  href: 'http://[::1]/' }

window does include brackets in ipv6 addresses:

window.location.hostname
"[::1]"

For browser requests we want these wrapped. Instead of url.parsing, this passes in a host object. An upstream fix is probably ideal but not as straight forward, I believe hosts are environment agnostic. @delvedor any thoughts? I could look into a client fix, or wait until elasticsearch-js@next?

To reproduce:

elasticsearch.hosts: http://[::1]:9200
server.host: "::0"

and visit any page using the angular connector, e.g. discover.

Closes #23764
Closes #9157

[elasticmachine]

Pinging @elastic/kibana-operations

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[delvedor]

Hello! The next client will no longer use url.parse since it is deprecated, but it uses the new WHATWG URL API, which should fix this issue :)

> new URL('http://[::1]')
URL {
  href: 'http://[::1]/',
  origin: 'http://[::1]',
  protocol: 'http:',
  username: '',
  password: '',
  host: '[::1]',
  hostname: '[::1]',
  port: '',
  pathname: '/',
  search: '',
  searchParams: URLSearchParams {},
  hash: '' }

[jbudz]

retest

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[joshdover]

So I'm ignorant about how most of our legacy code works, but why does any frontend code access Elasticsearch directly? Or in other words, how is it that anything parsed by Angular code ends up in our elasticsearch-js client?

[jbudz]

nice, story time:

Kibana 4.0.0 was initially a client side application that you provided your own server for. A server was thrown in before release, and instead of rewriting every endpoint, a proxy to elasticsearch through the Kibana server was made. We've migrated away from this over time but it still exists in courier.

elasticsearch-js has separate browser and server installs but they share some code.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[mistic]

LGTM

[w33ble]

I have not confirmed this, but I suspect they may have also closed #23431

Reading that issue again, I think that's unlikely actually...

[ypid-geberit]

From the timeline it looks as this patch has made it into kibana-7.0.0-beta1-x86_64.rpm but I have experienced the issue on beta1 just now. Can you test this?

[jbudz]

Didn't make it, it was close - the cutoff was on Feb 13. It'll be in rc1.

[w33ble]

@jbudz was there a reason this didn't make it into the 6.x branch at all? It's been an issue for a while, and this discuss issue seems to indicate that the fix works in 6.3.2.