[InfraUI] Add Discuss feedback links to Infrastructure and Logs

[Kerry350]

Summary

Implements #29349

This affects the K6 design only, so "Use K7 design" should be turned off in Kibana's advanced settings. This should be revisited for K7 once things are settled there.

There was no strict consensus on the ticket regarding copy, so this currently just says "Feedback", I think given it's a link it's actually clear as-is that it's an actionable link. However, I'm more than happy to change this if we do want to extend character count to "Have feedback?", "Give us feedback" etc. Maybe just "Feedback?"?.

(I've targeted this at master, so for the 7.0.0 release, but as this targets K6 design only, I'm not sure if this should just target the 6.x branch? Will K6 be available for a period in 7.0.0?)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• [ ] Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

[skh]

There was no strict consensus on the ticket regarding copy, so this currently just says "Feedback", I think given it's a link it's actually clear as-is that it's an actionable link. However, I'm more than happy to change this if we do want to extend character count to "Have feedback?", "Give us feedback" etc. Maybe just "Feedback?"?.

@formgeist did you come to a conclusion what you'd like best there?

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[formgeist]

I think the longer we make it the more "noisey" it is to have it in the top. Let's keep it "Feedback" and make that consistent for all. I'll create a ticket to update the APM option.

[skh]

Good work 👍

I've targeted this at master, so for the 7.0.0 release, but as this targets K6 design only, I'm not sure if this should just target the 6.x branch? Will K6 be available for a period in 7.0.0?

I'm not sure, but I think it's better to keep the differences between the branches as small as possible for as long as possible, and it doesn't hurt to have this change in master as well.

[formgeist]

@Kerry350 @skh To my knowledge, it's a hard switch to K7 for 7.0 at least from the UI design standpoint. I think it's good to have it fixed for master but backport to 6.x for the upcoming release. We'll hopefully have a better UI solution in place soon for 7.0 that will replace this button/link with a more global component in Kibana (as described in #29247)

[skh]

Yes, master and backport to 6.x is what I meant too. Apologies if that wasn't clear.

[Kerry350]

No worries, it was clear — thanks both! 👍