Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] User feedback link to Discuss #29247

Closed
formgeist opened this issue Jan 24, 2019 · 10 comments
Closed

[Design] User feedback link to Discuss #29247

formgeist opened this issue Jan 24, 2019 · 10 comments
Assignees
Labels
design Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Jan 24, 2019

Summary

image

Related to #29087, in preparation to move away from the old Kibana header, the APM app features a small but valuable option to inform users that we have a discussion forum where they can voice feedback and suggestions to the product. This feature is also present in Uptime, but I imagine will also be added to several other solution apps in Kibana.

For consistency across multiple apps and multiple views, it makes sense to show this option in the same place and position at all times. This naturally limits the placement to a few options.

Proposed solutions

Pre-K7 header

Related issue #29349

We implement the feedback option like in APM, in the top menu bar with a similar panel to show the copy and link. We can choose to change the design to possibly show a popover instead of the much more intrusive panel that is currently being displayed.

Post-K7 header

These mocks are nowhere near complete, just for visual presentation.

As we do away with the menu bar, breadcrumb is moved to the global header, the datepicker is set within the app itself. This means we have to find a new placement for this feedback option in the UI.

Kibana global header

One option could be to offer apps to enable a feedback button in the global header with copy and link to the Discuss forums. We'd like to deep-link to the specific app forum, so users won't have to do the digging themselves.

01 services

In-app placement

Another option would be to create a floating component that sits inside the app content area, which is most recognizable from other services such as Intercom and others where there's a floating icon button on the page. In this case it is positioned bottom left to avoid conflicting with toasts and most content on the page (when there's enough margin).

01b services - app feedback button hover

cc @elastic/kibana-design for your consideration and feedback

@formgeist formgeist added Team:APM All issues that need APM UI Team support design labels Jan 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist
Copy link
Contributor Author

Related PR #29457 as local nav changes have been implemented, the feedback link as it's currently positioned will be placed top left like this;

screenshot 2019-01-29 at 14 19 03

In my opinion we need to find a more appropriate solution for K7 than placing the link in the local navigation, at least like this.

@cchaos @snide I know you are swamped with details before release, but would it be possible we could talk 20-30 mins about this later today or tomorrow? Would like to know where you might stand on a solution for this.

@cchaos
Copy link
Contributor

cchaos commented Jan 29, 2019

@formgeist I can meet whenever. However, either of your ideas in the summary could work. I just don't know if there is any setup that allows apps to add into the Kibana header. The sidebar approach would work too, but I'd just make it a regular text link "APM Feedback" that sticks to the bottom of the sidebar instead of a floating button.

@ryankeairns
Copy link
Contributor

ryankeairns commented Jan 29, 2019

Adding to this...

The Canvas team used to have a similar feedback mechanism that sent an email though I don't recall where it was placed in the UI. There has been talk in the past week of potentially bringing it back which makes me think the solution should be universal. In other words, perhaps it could be something you control via a plugin setting (e.g. a url or email address) where if it exists, then we show a button in the header or side nav.

@sorenlouv
Copy link
Member

sorenlouv commented Jan 29, 2019

@ryankeairns Having this as a core plugin feature would be nice!

@formgeist
Copy link
Contributor Author

@ryankeairns Thanks for adding the Canvas view on this. I would also expect that the Codesearch team (cc @daveyholler) would have such a need to get feedback at least for the first few iterations of their solution.

@formgeist
Copy link
Contributor Author

Replaced by #29664

@cchaos
Copy link
Contributor

cchaos commented Feb 1, 2019

#29664 has been merged. You can check the PR summary for how to tap into that help item to add your feedback button.

@snide
Copy link
Contributor

snide commented Feb 1, 2019

Awesome job sneaking this stuff in so quick. Good job everyone!

@formgeist
Copy link
Contributor Author

@cchaos Excellent! Thanks again for getting this in so quick 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

7 participants