Prepare local nav styles for K7 #29457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Menu on the left, datepicker on the right
cchaos
added
Team:Platform-Design
|
Pinging @elastic/kibana-design |
This reverts commit c98ef9f.
💔 Build Failed |
💔 Build Failed |
This reverts commit db3d4ab.
cchaos
changed the title
cchaos
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
💔 Build Failed |
💔 Build Failed |
|
Looks like a connectivity issue. Jenkins test this |
💚 Build Succeeded |
ryankeairns
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
LGTM. In the hopes of saving you a little time, I went ahead and checked it in IE11 and Edge. In both cases it looked and worked as expected (screenshots below). I'll remove those smaller breakpoint styles for the mobile header height in the side nav PR.
IE11
Edge
|
Sweet thank you! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #20014 & #27902 finishing up, this PR adjusts the position and styles of the
kbn-top-navcomponent.Essentially, this PR
K6 examples
K7 examples
With title/breadcrumbs still existing in K7
Other updates/fixes
a. This fixes the shifting menu item when using EuiPopovers
b. In Timelion, you used to only see the query time if it was a saved sheet or if K7 was turned on. Now it always shows no matter the theme or state of the sheet.
Checklist
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility