Fix timelion data-render-complete attribute on resize #29320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a watch to the renderComplete promise to fix missing rendering of chart when the resize observer detect a change in size. Removed the existing resize observer.
It's need on the timelion app to resize since that app doesn't use visualize loader
markov00
added
bug
|
Pinging @elastic/kibana-app |
timroes
approved these changes
Jan 25, 2019
💚 Build Succeeded |
|
jenkins, test this (checking for flakyness) |
💚 Build Succeeded |
|
jenkins, test this (checking for flakyness) |
|
Thanks for tackling this @markov00! Any idea why it started failing so consistently all of a sudden? |
💚 Build Succeeded |
|
@stacey-gammon I think this bug was here since for a lot of time. I'm not sure but I think that we have introduced some slight changes on the styles of components, dashboard etc that introduced the problem of rerendering or resizing. Unfortunately I don't know more than that |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Jan 25, 2019
* Fix timelion missing renderer on resize Adding a watch to the renderComplete promise to fix missing rendering of chart when the resize observer detect a change in size. Removed the existing resize observer. * Revert removing observe resize It's need on the timelion app to resize since that app doesn't use visualize loader * Change double watch to watchgroup * Reenable skipped dashboard test
markov00
added a commit
that referenced
this pull request
Jan 28, 2019
* Fix timelion missing renderer on resize Adding a watch to the renderComplete promise to fix missing rendering of chart when the resize observer detect a change in size. Removed the existing resize observer. * Revert removing observe resize It's need on the timelion app to resize since that app doesn't use visualize loader * Change double watch to watchgroup * Reenable skipped dashboard test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28818
Fix #22561
Fix #24292
There is a special case, when trying to resize a bit the visualization in a dashboard, as shown in the screenshot, that trigger a new render cycle from the
visualize-chartloader, but doesn't complete a full rendering on the chart because the data doesn't change, thus thedata-render-completeis never switched to true.On #28818, I'm imagine that minor resize triggers when adding a visualization to the dashboard encounter the described bug, thus wrongly missing the render cycle avoiding set the
data-render-completeattribute to false.Extra: we have an extra resize-observer that trigger a check on the size every 500ms. We cannot get rid of the extra resize-observer because it's used directly from the timelion app itself.