Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: UI Functional Tests.test/functional/apps/dashboard/_embeddable_rendering·js - dashboard app using current data dashboard embeddable rendering adding saved searches #24292

Closed
kibanamachine opened this issue Oct 19, 2018 · 13 comments · Fixed by #24424
Closed

Failing test: UI Functional Tests.test/functional/apps/dashboard/_embeddable_rendering·js - dashboard app using current data dashboard embeddable rendering adding saved searches #24292

kibanamachine opened this issue Oct 19, 2018 · 13 comments · Fixed by #24424
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 19, 2018 •
edited
Loading

A test failed on a tracked branch


        Error: retry.try timeout: Error: expected false to equal true
    at Assertion.assert (node_modules/expect.js/index.js:96:13)
    at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
    at Assertion.(anonymous function) [as be] (node_modules/expect.js/index.js:69:24)
    at retry.try (test/functional/services/test_subjects.js:48:30)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
    at lastError (test/common/services/retry/retry_for_success.js:29:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.js:63:13)
    at <anonymous>

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 19, 2018
@tylersmalley tylersmalley added Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 19, 2018
@tylersmalley
Copy link
Contributor

@elastic/kibana-app

@Bargs Bargs mentioned this issue Oct 22, 2018
Merged
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@stacey-gammon
Copy link
Contributor

Details of the last one are:

│ debg findByCssSelector [data-test-subj~="storeTimeWithDashboard"]
             │ debg Flipping store time checkbox
             │ debg DashboardPage.clickSave
             │ debg TestSubjects.click(confirmSaveSavedObjectButton)
             │ debg Find.clickByCssSelectorWhenNotDisabled
             │ debg findByCssSelector [data-test-subj~="confirmSaveSavedObjectButton"]
             │ debg isGlobalLoadingIndicatorVisible
             │ debg TestSubjects.exists(globalLoadingIndicator)
             │ debg existsByDisplayedByCssSelector [data-test-subj~="globalLoadingIndicator"]
             │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-centos-1540276908140124597] adding template [kibana_index_template:.kibana] for index patterns [.kibana]
             │ debg awaitGlobalLoadingIndicatorHidden
             │ debg TestSubjects.find(globalLoadingIndicator-hidden)
             │ debg findByCssSelector [data-test-subj~="globalLoadingIndicator-hidden"]
             │ debg TestSubjects.existOrFail(saveDashboardSuccess)
             │ debg TestSubjects.exists(saveDashboardSuccess)
             │ debg existsByDisplayedByCssSelector [data-test-subj~="saveDashboardSuccess"]
             │ debg --- retry.try error: expected false to equal true
             │ debg TestSubjects.existOrFail(saveDashboardSuccess)
             │ debg TestSubjects.exists(saveDashboardSuccess)
             │ debg existsByDisplayedByCssSelector [data-test-subj~="saveDashboardSuccess"]
             │ debg --- retry.try failed again with the same message...
             │ debg TestSubjects.existOrFail(saveDashboardSuccess)
             │ debg TestSubjects.exists(saveDashboardSuccess)
             │ debg existsByDisplayedByCssSelector [data-test-subj~="saveDashboardSuccess"]
             │ debg --- retry.try failed again with the same message...
             │ debg TestSubjects.existOrFail(saveDashboardSuccess)
             │ debg TestSubjects.exists(saveDashboardSuccess)
             │ debg existsByDisplayedByCssSelector [data-test-subj~="saveDashboardSuccess"]
             │ debg --- retry.try failed again with the same message...
             │ debg TestSubjects.existOrFail(saveDashboardSuccess)
             │ debg TestSubjects.exists(saveDashboardSuccess)
             │ debg existsByDisplayedByCssSelector [data-test-subj~="saveDashboardSuccess"]
             │ debg --- retry.try failed again with the same message...
             │ debg TestSubjects.existOrFail(saveDashboardSuccess)
             │ debg TestSubjects.exists(saveDashboardSuccess)
             │ debg existsByDisplayedByCssSelector [data-test-subj~="saveDashboardSuccess"]
             │ debg --- retry.try failed again with the same message...
             │ debg TestSubjects.existOrFail(saveDashboardSuccess)
             │ debg TestSubjects.exists(saveDashboardSuccess)
             │ debg existsByDisplayedByCssSelector [data-test-subj~="saveDashboardSuccess"]
             │ debg --- retry.try failed again with the same message...
             │ debg TestSubjects.existOrFail(saveDashboardSuccess)
             │ debg TestSubjects.exists(saveDashboardSuccess)

and the image is:
screen shot 2018-10-23 at 7 56 08 am

Not able to tell if the save passed and the toast was just missed, or if something else weird happened...

@stacey-gammon
Copy link
Contributor

My current theory is the line │ info [o.e.c.m.MetaDataIndexTemplateService] [kibana-ci-immutable-centos-1540276908140124597] adding template [kibana_index_template:.kibana] for index patterns [.kibana]

If this is slowing down the execution the save toast may have disappeared by the time we check for it.

Two questions:

  1. Why is this line being output (was not shown locally when running only this test suite).
  2. How quickly are toasts being hidden? Old style toasts were shown "forever" to eliminate this issue. I'm not sure if new style toasts have this as well. Needs investigation.

This was referenced Oct 23, 2018
Closed
Merged
@LeeDr
Copy link

LeeDr commented Oct 24, 2018

This one issue has caused 62 build failures in the last 7 days;

image

@stacey-gammon
Copy link
Contributor

It's been skipped in @Bargs Query PR. I have a PR here that brings it back with a potential fix: #24424

Though won't know for sure it helps without more test runs. So far three passes (excluding an unrelated failure).

@LeeDr LeeDr self-assigned this Oct 24, 2018
@kibanamachine kibanamachine reopened this Jan 23, 2019
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@spalger spalger mentioned this issue Jan 24, 2019
Merged
@markov00 markov00 mentioned this issue Jan 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for toast before waiting for page to finish loading to avoid mi… stacey-gammon/kibana
5 participants
@tylersmalley @spalger @LeeDr @stacey-gammon @kibanamachine