-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use savedObjectsClient to get index-patterns #25630
Conversation
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
We're also using a canvas web service (/api/canvas/es_fields
) to retrieve the fields of a given index. Can we use the savedObjectsClient for getting the fields as well?
It's not a blocker for this PR, but we should make the same change for getFields
.
Not without some extra leg work. Kibana uses the The GIS application is using this solution to access the index patterns service in react
Then react code can import the service like this
|
💔 Build Failed |
💚 Build Succeeded |
fixes #25389
Index patterns were getting loaded via a canvas web service
/api/canvas/es_indices
. Under the covers,es_indices
was quering directly against the kibana elasticsearch index.This PR removes the
es_indices
web service and just uses the savedObjectsClient