-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/translate monitoring server #25195
Feature/translate monitoring server #25195
Conversation
second merge
💔 Build Failed |
💔 Build Failed |
Pinging @elastic/kibana-monitoring |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please look at my suggestions.
x-pack/plugins/monitoring/server/cluster_alerts/verify_monitoring_license.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/cluster_alerts/verify_monitoring_license.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/lib/cluster/get_cluster_stats.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/lib/cluster/get_cluster_stats.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/lib/cluster/get_cluster_stats.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/lib/cluster/get_clusters_from_request.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/lib/elasticsearch/nodes/lookups.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded |
💚 Build Succeeded |
* Translate monitoring server(without metrics folder) * Fix issue * Fix issues * Fix issues * Remove eslint rule disabling
Translate monitoring -> server (without metrics folder)
Fixes: #24713