Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/translate monitoring server #25195

Merged

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Nov 6, 2018

Translate monitoring -> server (without metrics folder)

Fixes: #24713

@Nox911 Nox911 requested a review from maryia-lapata November 6, 2018 09:48
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-monitoring

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please look at my suggestions.

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata merged commit ef4fa62 into elastic:master Nov 21, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Nov 21, 2018
* Translate monitoring server(without metrics folder)

* Fix issue

* Fix issues

* Fix issues

* Remove eslint rule disabling
maryia-lapata added a commit that referenced this pull request Nov 21, 2018
* Translate monitoring server(without metrics folder)

* Fix issue

* Fix issues

* Fix issues

* Remove eslint rule disabling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants