-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing map bounds #25040
fixing map bounds #25040
Conversation
💚 Build Succeeded |
after testing this PR, i found that it removes the here's a quick comparison of this behavior on the current PR vs master: |
I'm also noticing the query that courier sends to ES upon clicking to update bounds is missing the on master, this PR, and 6.4:
on 6.3:
|
and that info is not in filter agg ? full request:
|
I think this actually fixes the issue (on master at least). The But this doesn't explain your first gif!!!! So basically, I cannot reproduce that part.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After rebasing on the latest master, things are now working for me as expected -- the zooming to fit bounds is functioning correctly, and the toast is still gone. This is consistent with what @thomasneirynck reported yesterday.
@ppisljar If everything is working on your end too I think we are good to go here.
Pinging @elastic/kibana-app |
cd8441f
to
f2715f0
Compare
💚 Build Succeeded |
@ppisljar can this be backported to v6.5.1 as well? |
@thomasneirynck I think it was backported in #25787 so it should be in |
FYI, same error and screenshot following "getting started on kibana" video, adding sample data of flights, then adding a point map and trying to zoom... using elasticcloud default cluster template...Version: 6.5.1 latest (cross post from #23261) |
@ppisljar was this backported to 6.5.1? |
not sure it made it to 6.5.1 but it was merged into 6.5 branch 13 days ago. |
great thx @ppisljar ! |
Summary
Tries to resolve #23261
during aggconfig refactoring this part was not updated to use the new way to create AggConfig.
we should no longer create AggConfig's maually but should use aggs.createAggConfig method.
it seems that in this case we don't want to add this aggregation to the list of all aggs thats why we call it with
{ addToAggConfigs: false }
however after this fix i no longer receive error messages, but it also seems that the fit bounds is now behaving as described in original issue ...
@thomasneirynck could you double check this ? i am on vacation so it might take a bit before i get back to this.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately