fixing map bounds

[ppisljar]

Summary

Tries to resolve #23261

during aggconfig refactoring this part was not updated to use the new way to create AggConfig.
we should no longer create AggConfig's maually but should use aggs.createAggConfig method.

it seems that in this case we don't want to add this aggregation to the list of all aggs thats why we call it with { addToAggConfigs: false }

however after this fix i no longer receive error messages, but it also seems that the fit bounds is now behaving as described in original issue ...

@thomasneirynck could you double check this ? i am on vacation so it might take a bit before i get back to this.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• [ ] This was checked for cross-browser compatibility, including a check against IE11
• [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• [ ] This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[lukeelmers]

after testing this PR, i found that it removes the undefined error (yay!) but re-introduces the bug that was described in the original issue (as @ppisljar describes above). i'm diving deeper to see if i can sort this out.

here's a quick comparison of this behavior on the current PR vs master:

this PR...

master...

[lukeelmers]

I'm also noticing the query that courier sends to ES upon clicking to update bounds is missing the geo_bounding_box:

on master, this PR, and 6.4:

  "query": {
    "bool": {
      "must": [
        {
          "match_all": {}
        }
      ],
      "filter": [],
      "should": [],
      "must_not": []
    }
  }

on 6.3:

  "query": {
    "bool": {
      "must": [
        {
          "match_all": {}
        },
        {
          "match_all": {}
        },
        {
          "geo_bounding_box": {
            "ignore_unmapped": true,
            "geo.coordinates": {
              "bottom_right": {
                "lat": 44.33956524809713,
                "lon": -120.58593750000001
              },
              "top_left": {
                "lat": 51.17934297928929,
                "lon": -125.85937500000001
              }
            }
          }
        },
        {
          "range": {
            "@timestamp": {
              "gte": 1541196237041,
              "lte": 1541197137041,
              "format": "epoch_millis"
            }
          }
        }
      ],
      "filter": [],
      "should": [],
      "must_not": []
    }
  },

[ppisljar]

and that info is not in filter agg ? full request:

{
  "aggs": {
    "filter_agg": {
      "filter": {
        "geo_bounding_box": {
          "ignore_unmapped": true,
          "geo.coordinates": {
            "top_left": {
              "lat": 66.60225,
              "lon": -166.706545
            },
            "bottom_right": {
              "lat": 12.040769999999998,
              "lon": -53.767084999999994
            }
          }
        }
      },
      "aggs": {
        "2": {
          "geohash_grid": {
            "field": "geo.coordinates",
            "precision": 3
          },
          "aggs": {
            "3": {
              "geo_centroid": {
                "field": "geo.coordinates"
              }
            }
          }
        }
      }
    }
  },
  "size": 0,
  "_source": {
    "excludes": []
  },
  "stored_fields": [
    "*"
  ],
  "script_fields": {},
  "docvalue_fields": [
    {
      "field": "@timestamp",
      "format": "date_time"
    },
    {
      "field": "relatedContent.article:modified_time",
      "format": "date_time"
    },
    {
      "field": "relatedContent.article:published_time",
      "format": "date_time"
    },
    {
      "field": "utc_time",
      "format": "date_time"
    }
  ],
  "query": {
    "bool": {
      "must": [
        {
          "match_all": {}
        },
        {
          "range": {
            "@timestamp": {
              "gte": 1540802241390,
              "lte": 1541407041390,
              "format": "epoch_millis"
            }
          }
        }
      ],
      "filter": [],
      "should": [],
      "must_not": []
    }
  }
}

[thomasneirynck]

@lukeelmers

I think this actually fixes the issue (on master at least). The Cannot read property reduce of undefined error was due to the AggConfig no longer having the .vis property and not using the new API correctly, which this PR resolves.

But this doesn't explain your first gif!!!! So basically, I cannot reproduce that part....

[lukeelmers]

After rebasing on the latest master, things are now working for me as expected -- the zooming to fit bounds is functioning correctly, and the toast is still gone. This is consistent with what @thomasneirynck reported yesterday.

@ppisljar If everything is working on your end too I think we are good to go here.

[elasticmachine]

Pinging @elastic/kibana-app

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[thomasneirynck]

@ppisljar can this be backported to v6.5.1 as well?

[lukeelmers]

@thomasneirynck I think it was backported in #25787 so it should be in v6.5.1 or v6.5.2 at this point.

[marcosnr]

FYI, same error and screenshot following "getting started on kibana" video, adding sample data of flights, then adding a point map and trying to zoom... using elasticcloud default cluster template...Version: 6.5.1 latest (cross post from #23261)

[thomasneirynck]

@ppisljar was this backported to 6.5.1?

[ppisljar]

not sure it made it to 6.5.1 but it was merged into 6.5 branch 13 days ago.

[thomasneirynck]

great thx @ppisljar !