[ML] Adds an About panel to the file data visualizer landing page #24260
Conversation
peteharverson
added
release_note:enhancement
review
v7.0.0
:ml
Feature:Anomaly Detection
peteharverson
requested review from
walterra,
alvarezmelissa87,
jgowdyelastic and
gchaps
|
Pinging @elastic/ml-ui |
peteharverson
changed the title
💚 Build Succeeded |
|
@peteharverson The screenshot shows three different names for the File Data Visualizer in the breadcrumb, tab name, and text. My suggestion is to use "File Data Visualizer" in all three places. I edited the text to make it more concise and to address the user as "you." For readability, and because the user can see on the screen that they need to upload a file, I combined the first two paragraphs. Make sure you capitalize Elasticsearch. Visualize data from a log file The File Data Visualizer helps you understand the fields and metrics in a log file. Upload your file, analyze its data, and then choose which data to import into your Elasticsearch index. The File Data Visualizer supports these file formats:
You can upload files up to 100 MB. This feature is experimental. Got feedback? Please create an issue in GitHub. |
|
@peteharverson I realize this has been merged already and FF is around the corner but I had a few questions if we're going to be linking directly from the home page. I still don't see a link to ML in Basic, should it be there by now? The deep link (/app/ml#/datavisualizer) in master doesn't seem to work either. I'm redirected to the jobs page and error out. I have a feeling that might be the wrong link as well 😄 I'm pulling from the description here: #24226 For the landing page, would it be possible to adopt the same design concept we have for empty states? You can see here: https://elastic.github.io/eui/#/display/emptyprompt. The icon is on the top, followed by a description below and then an action. This is in a number of places in Kibana already and we plan to make this experience consistent moving forward.
Canvas has a very similar workflow / empty state as you actually. Something like this might work if it's possible to implement. It seems a bit off to me that the upload action is above the context. After speaking to @grabowskit a bit, I understand why it is but if at all, it'd be nice to be consistent. Any chance we can borrow some code here?
In the current screenshot it's not exactly obvious to me that this experience is experimental. I'm expected to read all of the text in order to understand that. When in reality, that's normally not the case. If we're going to be linking to the homepage and expecting net new users to be utilizing this feature, would be possible to make it a bit more obvious? I'm sure @elastic/kibana-design may have more input here, but we use a tag in the add data tutorials for explicitly defining a beta module. Maybe we could do something similar at the top of the empty state card?
I haven't been in direct contact with this group much so I'm happy to discuss live, but given FF is Weds, I think we're running out of time. I'd imagine the ML / Basic landing page would need to be there beforehand. We're blocked on the home page link #24226 until this is accessible. Is the target release still 6.5? |
|
@alexfrancoeur This feature is currently on a feature branch that I will merge into master tomorrow. I don't know which page you'll want to link to. The text "Import a JSON, CSV, or text file" added in #24226 suggests to me that you want to link directly to the File Data Visualizer, which is We've discussed internally adding "Experimental" or "Beta" labels elsewhere in the app and I agree it is needed. I'll look to do that before FF. I'm planning on taking a look at a redesign of the File Data Visualizer landing page and the flow through the pages. |
* [ML] File datavisualizer initial commit (#22828) * [ML] File datavisualizer initial commit * removing mocked data and adding initial stats * adding card styling to fields * Revert "". accidentally added with no commit message This reverts commit d762d20b706e6a770e631f863b9e7d8879bb7ee6. * adding date type to timestamp field * renaming FileStats to FieldsStats * code clean up * changes based on review * changes to error handling * [ML] Adding file datavisualizer overrides (#23194) * [ML] Adding file datavisualizer overrides * improvements to overrides * removing comment * small refactor * removing accidentally added file * updates based on review * fixing broken test * adding missing grok pattern override * fixing test * [ML] Refactoring override option lists (#23424) * [ML] Refactoring override option lists * moving lists out of class * updating test snapshot * [ML] Fixing field editing (#23500) * [ML] Changes to timestamp formats (#23498) * [ML] Changes to timestamp formats * updating test snapshot * [ML] Allow Datavisualizer use on basic license (#23748) * [ML] Allow ML use on basic license * removing timeout change * adding permission checks * updating tests * removing unnecessary checks * [ML] Adds new page for choosing file or index based data visualizer (#23763) * [ML] Adding license check to datavisualizer landing page (#23809) * [ML] Adding license check to datavisualizer landing page * removing comments * updating redirect to landing page * [ML] Adding ability to upload data to elasticsearch from datavisualizer (#24042) * [ML] Initial work for delimited file upload * adding results links cards * adding nav menu * removing accidental debugger * initial work for importing semi structured text * using ingest pipeline for import * adding json importer and better error reporting * better progress steps * time range added to results links * first import only creates index and pipeline * adding status constants * using status constants * adding explanation comment * updating yarn.lock * changes based on review * fixing space * fixing space again, stort it out git * removing oversized background container causing constant scrollbar * [ML] Adding basic license check when loading privileges (#24173) * [ML] Adding basic license check * missing import * [ML] Adds an About panel to the file data visualizer landing page (#24260) * [ML] Adds an About panel to the file data visualizer landing page * [ML] Remove unnecessary style from file data visualizer scss * [ML] Adding better error reporting for reading and importing data (#24269) * [ML] Adding better error reporting for reading and importing data * changes to endpoint errors * displaying errors * step logic refactor * removing log statements * [ML] Switch file data visualizer to use Papa Parse for CSV parsing (#24329) * [ML] Fixes layout of Data Visualizer selector page for IE (#24387) * [ML] Adding ability to override various settings when importing data (#24346) * [ML] Adding ability to override various settings when importing data * second commit with most of the outstanding code * improving index pattern name validation * better index pattern matching * adding comments * adding empty index pattern check * changes based on review * fixing test
* [ML] File datavisualizer initial commit (elastic#22828) * [ML] File datavisualizer initial commit * removing mocked data and adding initial stats * adding card styling to fields * Revert "". accidentally added with no commit message This reverts commit d762d20b706e6a770e631f863b9e7d8879bb7ee6. * adding date type to timestamp field * renaming FileStats to FieldsStats * code clean up * changes based on review * changes to error handling * [ML] Adding file datavisualizer overrides (elastic#23194) * [ML] Adding file datavisualizer overrides * improvements to overrides * removing comment * small refactor * removing accidentally added file * updates based on review * fixing broken test * adding missing grok pattern override * fixing test * [ML] Refactoring override option lists (elastic#23424) * [ML] Refactoring override option lists * moving lists out of class * updating test snapshot * [ML] Fixing field editing (elastic#23500) * [ML] Changes to timestamp formats (elastic#23498) * [ML] Changes to timestamp formats * updating test snapshot * [ML] Allow Datavisualizer use on basic license (elastic#23748) * [ML] Allow ML use on basic license * removing timeout change * adding permission checks * updating tests * removing unnecessary checks * [ML] Adds new page for choosing file or index based data visualizer (elastic#23763) * [ML] Adding license check to datavisualizer landing page (elastic#23809) * [ML] Adding license check to datavisualizer landing page * removing comments * updating redirect to landing page * [ML] Adding ability to upload data to elasticsearch from datavisualizer (elastic#24042) * [ML] Initial work for delimited file upload * adding results links cards * adding nav menu * removing accidental debugger * initial work for importing semi structured text * using ingest pipeline for import * adding json importer and better error reporting * better progress steps * time range added to results links * first import only creates index and pipeline * adding status constants * using status constants * adding explanation comment * updating yarn.lock * changes based on review * fixing space * fixing space again, stort it out git * removing oversized background container causing constant scrollbar * [ML] Adding basic license check when loading privileges (elastic#24173) * [ML] Adding basic license check * missing import * [ML] Adds an About panel to the file data visualizer landing page (elastic#24260) * [ML] Adds an About panel to the file data visualizer landing page * [ML] Remove unnecessary style from file data visualizer scss * [ML] Adding better error reporting for reading and importing data (elastic#24269) * [ML] Adding better error reporting for reading and importing data * changes to endpoint errors * displaying errors * step logic refactor * removing log statements * [ML] Switch file data visualizer to use Papa Parse for CSV parsing (elastic#24329) * [ML] Fixes layout of Data Visualizer selector page for IE (elastic#24387) * [ML] Adding ability to override various settings when importing data (elastic#24346) * [ML] Adding ability to override various settings when importing data * second commit with most of the outstanding code * improving index pattern name validation * better index pattern matching * adding comments * adding empty index pattern check * changes based on review * fixing test
|
@jgowdyelastic thanks for the quick response. I see that the feature branch was just merged, congrats! With FF tomorrow there still is a bit more time for design tweaks. Do you think you'll be able to address any of my comments or @snides? I think this experimental label is important (and see it on the previous page) and if we could use a similar upload component as Canvas that would be amazing. I do realize we are running out of time though |
|
@alexfrancoeur yes, this follow up PR is on its way |
|
@jgowdyelastic 🙇 🙇 🙇 brilliant! |
* [ML] File datavisualizer initial commit (#22828) * [ML] File datavisualizer initial commit * removing mocked data and adding initial stats * adding card styling to fields * Revert "". accidentally added with no commit message This reverts commit d762d20b706e6a770e631f863b9e7d8879bb7ee6. * adding date type to timestamp field * renaming FileStats to FieldsStats * code clean up * changes based on review * changes to error handling * [ML] Adding file datavisualizer overrides (#23194) * [ML] Adding file datavisualizer overrides * improvements to overrides * removing comment * small refactor * removing accidentally added file * updates based on review * fixing broken test * adding missing grok pattern override * fixing test * [ML] Refactoring override option lists (#23424) * [ML] Refactoring override option lists * moving lists out of class * updating test snapshot * [ML] Fixing field editing (#23500) * [ML] Changes to timestamp formats (#23498) * [ML] Changes to timestamp formats * updating test snapshot * [ML] Allow Datavisualizer use on basic license (#23748) * [ML] Allow ML use on basic license * removing timeout change * adding permission checks * updating tests * removing unnecessary checks * [ML] Adds new page for choosing file or index based data visualizer (#23763) * [ML] Adding license check to datavisualizer landing page (#23809) * [ML] Adding license check to datavisualizer landing page * removing comments * updating redirect to landing page * [ML] Adding ability to upload data to elasticsearch from datavisualizer (#24042) * [ML] Initial work for delimited file upload * adding results links cards * adding nav menu * removing accidental debugger * initial work for importing semi structured text * using ingest pipeline for import * adding json importer and better error reporting * better progress steps * time range added to results links * first import only creates index and pipeline * adding status constants * using status constants * adding explanation comment * updating yarn.lock * changes based on review * fixing space * fixing space again, stort it out git * removing oversized background container causing constant scrollbar * [ML] Adding basic license check when loading privileges (#24173) * [ML] Adding basic license check * missing import * [ML] Adds an About panel to the file data visualizer landing page (#24260) * [ML] Adds an About panel to the file data visualizer landing page * [ML] Remove unnecessary style from file data visualizer scss * [ML] Adding better error reporting for reading and importing data (#24269) * [ML] Adding better error reporting for reading and importing data * changes to endpoint errors * displaying errors * step logic refactor * removing log statements * [ML] Switch file data visualizer to use Papa Parse for CSV parsing (#24329) * [ML] Fixes layout of Data Visualizer selector page for IE (#24387) * [ML] Adding ability to override various settings when importing data (#24346) * [ML] Adding ability to override various settings when importing data * second commit with most of the outstanding code * improving index pattern name validation * better index pattern matching * adding comments * adding empty index pattern check * changes based on review * fixing test
|
Experimental labels have been added to the File Data Visualizer landing page and import page in #24485 |
Adds a panel to the file data visualizer landing page which gives a brief overview of the functionality, including the file formats that are supported and a note that it is an experimental feature: