[WIP] Adds 'upload data from file' to Kibana home page #24226

ryankeairns · 2018-10-18T17:18:18Z

~~WIP: The 'Upload data from file' link now points to /app/ml#/filedatavisualizer (check that this view/work has been merged (#24423) to master before merging this PR).~~ merged and rebased this PR.

Summary

Adds 'upload file' ~~and 'functionbeat'~~ to home page per #23777 .

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
~~Unit or functional tests were updated or added to match the most common scenarios~~
This was checked for keyboard-only and screenreader accessibility

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2018-10-18T19:13:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-18T22:59:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-19T00:55:37Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-19T06:01:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-19T18:27:35Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-19T23:13:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ryankeairns · 2018-10-22T12:52:51Z

retest

ryankeairns · 2018-10-22T12:55:18Z

retest

alexfrancoeur · 2018-10-22T15:25:02Z

@ryankeairns from the screenshot it looks like we're defaulting to highlight only the index pattern if there is no data. In general, I think we can remove this conditional logic now that we have the splash screen. This was meant to highlight sample data a bit more. @nreese can provide some details around the initial implementation.

@grabowskit do we have a URL that we can plugin here for the upload a file option?

alexfrancoeur · 2018-10-22T15:25:22Z

Woops, looks like the description was updated with the appropriate URL

ryankeairns · 2018-10-22T15:44:21Z

@alexfrancoeur the screenshot picked up my mouse hovering that element. I'll update the screenshot.

ryankeairns · 2018-10-22T15:59:38Z

retest

nreese · 2018-10-22T17:18:41Z

src/core_plugins/kibana/public/home/components/add_data.js

@@ -209,16 +214,35 @@ const AddDataUi = ({ apmUiEnabled, isNewKibanaInstance, intl }) => {
            </EuiLink>
          </EuiText>
        </EuiFlexItem>
+        <EuiFlexItem className={footerItemClasses}>


This link needs to be added conditionally since ML plugin will not always be installed or enabled.

Also, why is the csv import in the ML plugin? Maybe the CSV import needs to be put into its own plugin.

@nreese in the future, we'd like to implement a full workflow. The ML team introduced this as it has some intelligence behind it. This will evolve into an "autogrok" capability for your pipeline. You can imagine this in the future where you upload a file to test it out, end with a pipeline and then add that pipeline config through a UI. But yes, I agree, there are plenty of details to hash out here - this is the first iteration of the UI

@nreese Would this entail doing something like:

const mlEnabled = chrome.getInjected('mlEnabled'); ... if (mlEnabled === true) {<EuiFlexItem ... />}

My intent here was to get the ball rolling on this change, but I'm getting a little out of my depth :) Thanks for the feedback!

I think I'm getting close with something like

{mlEnabled !== false ? <EuiFlexItem>...</EuiFlexItem> : null}

yes, but you will have to add mlEnabled to the injected vars. mlEnabled is added by the APM application but that may not be enabled/installed either. I think the best bet is to add mlEnabled to https://github.com/elastic/kibana/blob/master/x-pack/plugins/ml/index.js and then check that value for displaying the FlexItem

src/core_plugins/kibana/public/home/components/__snapshots__/add_data.test.js.snap

gchaps · 2018-10-22T17:47:31Z

src/core_plugins/kibana/public/home/components/__snapshots__/add_data.test.js.snap

+          type="button"
+        >
+          <FormattedMessage
+            defaultMessage="Import a JSON, CSV or text file"


Import a JSON, CSV or text file -> Import a JSON, CSV, or text file (add comma after CSV)

elasticmachine · 2018-10-22T20:28:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-22T20:42:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ryankeairns · 2018-10-22T21:19:30Z

retest

jgowdyelastic · 2018-10-22T21:42:35Z

The text "Import a JSON, CSV, or text file" suggests to me that you want to link directly to the File Data Visualizer page, the address of which is /app/ml#/filedatavisualizer.

The current link being used here (/app/ml#/datavisualizer) will go to the Data Visualizer landing page which looks like this:

This is currently on a feature branch and will be merged tomorrow in time for FF.

elasticmachine · 2018-10-22T22:23:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-23T00:06:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ryankeairns · 2018-10-23T02:25:58Z

@alexfrancoeur cc:/ @nreese I think we need to tag in an engineer to finish this last conditional piece around showing the 'Upload data from file' link. My intent was to get this rolling from the design side and I think we've eclipsed my Kibana-foo for finishing the last recommendation from Nathan: #24226 (comment)

Is there somebody who could jump in and put this over the finish line?
I've updated the link per @jgowdyelastic 's comment.

Thanks!

elasticmachine · 2018-10-23T04:03:34Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

nreese · 2018-10-23T15:28:28Z

@ryankeairns I will create a PR against yours that finishes the conditional stuff

ryankeairns · 2018-10-23T20:30:13Z

@nreese @alexfrancoeur rebased this PR, checked that the link to the new ML page worked.

elasticmachine · 2018-10-23T22:45:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

move mlEnabled to ml plugin

ryankeairns · 2018-10-24T01:29:46Z

@elastic/apm @jgowdyelastic @alexfrancoeur This should be ready to go, please take a look! In particular, this PR moves mlEnabled from APM to ML... will that cause any issues?

elasticmachine · 2018-10-24T03:30:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

formgeist · 2018-10-24T06:28:48Z

@sqren Does this affect us and our ML integration in particular?

sorenlouv · 2018-10-24T10:50:34Z

@formgeist Not sure. We will need to test it to make sure it doesn't.

alexfrancoeur

@ryankeairns LGTM though you may need to merge with master to get #24438, I'm not seeing the latest in your pull

elasticmachine · 2018-10-24T13:04:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

gchaps · 2018-10-24T14:36:16Z

@ryankeairns, @alexfrancoeur, @jgowdyelastic If its not too late, here are some suggested edits that make the text easier to read.

Import data

Import and visualize data from a log file. You can upload files up to 100 MB.

Upload file

(Added import in the first sentence to tie it to the title. Added space before MB. Does Upload file work?)

Select an index pattern

Visualize the data in an existing Elasticsearch index.

Select index

("Select an index pattern" reads better than "pick index pattern)

Start trial

To experience the full Machine Learning features that a Platinum subscription has to offer, start a 30-day trial.

(Removed "from the license management page" because I'm assuming that clicking the button takes the user to that page.)

alexfrancoeur · 2018-10-24T15:17:18Z

@gchaps thanks for the feedback! I think this is more related to the ML portion of the UI and something that @jgowdyelastic may be able to adjust either before or after FF. This PR is specific to the link on the home page which I believe your have already provided suggestions for.

@ryankeairns @nreese will we be good to merge by EOD?

ryankeairns · 2018-10-24T15:28:54Z

@alexfrancoeur I think we just need some reassurance or approvals from the APM and ML teams based on the work that @nreese did in this PR. Functionally, it works. We're just not certain that moving mlEnabled will have any unintended consequences. I'm basically passing along that concern from Nathan, hopefully I've got that straight.

peteharverson · 2018-10-24T15:40:40Z

@gchaps I will make the edits to the ML Data Visualizer landing page that you suggested in #24226 (comment). As @alexfrancoeur said, that page is only accessed from within the ML plugin. The edits to the page accessed from the Home page were completed in #24438 and #24485.

peteharverson

A couple of suggested edits to the link to the ML File Data Visualizer, plus a typo

src/core_plugins/kibana/public/home/components/add_data.js

ryankeairns · 2018-10-24T16:14:41Z

Made the edits suggested by @peteharverson

peteharverson · 2018-10-24T16:20:31Z

x-pack/plugins/ml/index.js

+      injectDefaultVars(server) {
+        const config = server.config();
+        return {
+          mlEnabled: config.get('xpack.ml.enabled'),


Is this just looking for the xpack.ml.enabled setting in kibana.yml? If so, using this as the check as to whether to add the 'Upload data from log file' link to the Home page LGTM.

I believe APM have been using this mlEnabled flag to check whether to add a link to creating ML jobs from APM dashboards, but that is being edited in #24486 as they now need to check the type of license, and not just whether the ML feature is enabled.

alexfrancoeur · 2018-10-24T18:04:05Z

Given that FF is EoD, would it be possible to merge today and address any issues that APM may have after? As @peteharverson mentioned, it sounds like they already have a bug #24486 they need to address. I don't believe we need to check for license. I feel like we're already using this flag on the homepage in Cloud to detect if whether or not we should be showing ML on the homepage (this may not be the case though).

formgeist · 2018-10-24T18:11:26Z

@alexfrancoeur You don't need to wait for us to merge, our issues are not directly related to the moving of the mlEnabled flag, but rather the changes to the ML licensing as @peteharverson mentioned. We're working on a fix.

elasticmachine · 2018-10-24T18:26:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

nreese

lgtm
code review, tested changes in chrome

alexfrancoeur · 2018-10-24T19:07:12Z

I think we're good here then, @ryankeairns want to merge & backport?

* adds upload file and functionbeat to home * removes functionbeat, adds ml file upload href * remove functionbeat callout, add ml file url * fix tests for basepath * less caveman sounding * update code editor snapshot * make link conditional, copy changes * update ml link * move mlEnabled to ml plugin * copy edits

ryankeairns added WIP Work in progress v7.0.0 v6.5.0 labels Oct 18, 2018

ryankeairns requested a review from alexfrancoeur October 18, 2018 17:18

ryankeairns mentioned this pull request Oct 18, 2018

Kibana Home enhancements for new beta ingestion options #23777

Closed

ryankeairns changed the title ~~[WIP] Adds upload file and functionbeat to Kibana home page~~ [WIP] Adds 'upload data from file' to Kibana home page Oct 19, 2018

nreese reviewed Oct 22, 2018

View reviewed changes

gchaps reviewed Oct 22, 2018

View reviewed changes

alexfrancoeur mentioned this pull request Oct 22, 2018

[ML] Adds an About panel to the file data visualizer landing page #24260

Merged

update ml link

9b61b31

ryankeairns force-pushed the rk/23777-home-page branch from 4576370 to 9b61b31 Compare October 23, 2018 20:28

ryankeairns removed the WIP Work in progress label Oct 23, 2018

nreese and others added 2 commits October 23, 2018 19:01

move mlEnabled to ml plugin

7ce09b4

Merge pull request #1 from nreese/ryankeairns-rk/23777-home-page

a634103

move mlEnabled to ml plugin

alexfrancoeur approved these changes Oct 24, 2018

View reviewed changes

peteharverson reviewed Oct 24, 2018

View reviewed changes

src/core_plugins/kibana/public/home/components/add_data.js Outdated Show resolved Hide resolved

src/core_plugins/kibana/public/home/components/add_data.js Outdated Show resolved Hide resolved

src/core_plugins/kibana/public/home/components/add_data.js Outdated Show resolved Hide resolved

copy edits

ed5f86c

peteharverson reviewed Oct 24, 2018

View reviewed changes

nreese approved these changes Oct 24, 2018

View reviewed changes

ryankeairns merged commit 03d7294 into elastic:master Oct 24, 2018

ryankeairns mentioned this pull request Oct 24, 2018

[6.x] [WIP] Adds 'upload data from file' to Kibana home page (#24226) #24533

Merged

[WIP] Adds 'upload data from file' to Kibana home page #24226

[WIP] Adds 'upload data from file' to Kibana home page #24226

Conversation

ryankeairns commented Oct 18, 2018 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Oct 18, 2018

💔 Build Failed

elasticmachine commented Oct 18, 2018

💔 Build Failed

elasticmachine commented Oct 19, 2018

💔 Build Failed

elasticmachine commented Oct 19, 2018

💔 Build Failed

elasticmachine commented Oct 19, 2018

💔 Build Failed

elasticmachine commented Oct 19, 2018

💔 Build Failed

ryankeairns commented Oct 22, 2018

ryankeairns commented Oct 22, 2018

alexfrancoeur commented Oct 22, 2018

alexfrancoeur commented Oct 22, 2018

ryankeairns commented Oct 22, 2018

ryankeairns commented Oct 22, 2018

nreese Oct 22, 2018

Choose a reason for hiding this comment

alexfrancoeur Oct 22, 2018

Choose a reason for hiding this comment

ryankeairns Oct 22, 2018

Choose a reason for hiding this comment

ryankeairns Oct 22, 2018

Choose a reason for hiding this comment

nreese Oct 22, 2018

Choose a reason for hiding this comment

gchaps Oct 22, 2018

Choose a reason for hiding this comment

elasticmachine commented Oct 22, 2018

💚 Build Succeeded

elasticmachine commented Oct 22, 2018

💔 Build Failed

ryankeairns commented Oct 22, 2018

jgowdyelastic commented Oct 22, 2018 • edited Loading

elasticmachine commented Oct 22, 2018

💚 Build Succeeded

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

ryankeairns commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

nreese commented Oct 23, 2018

ryankeairns commented Oct 23, 2018

elasticmachine commented Oct 23, 2018

💚 Build Succeeded

ryankeairns commented Oct 24, 2018

elasticmachine commented Oct 24, 2018

💚 Build Succeeded

formgeist commented Oct 24, 2018

sorenlouv commented Oct 24, 2018

alexfrancoeur left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 24, 2018

💚 Build Succeeded

gchaps commented Oct 24, 2018

alexfrancoeur commented Oct 24, 2018

ryankeairns commented Oct 24, 2018

peteharverson commented Oct 24, 2018

peteharverson left a comment

Choose a reason for hiding this comment

ryankeairns commented Oct 24, 2018

peteharverson Oct 24, 2018

Choose a reason for hiding this comment

alexfrancoeur commented Oct 24, 2018

formgeist commented Oct 24, 2018

elasticmachine commented Oct 24, 2018

💚 Build Succeeded

nreese left a comment

Choose a reason for hiding this comment

alexfrancoeur commented Oct 24, 2018

ryankeairns commented Oct 18, 2018 •

edited

Loading

jgowdyelastic commented Oct 22, 2018 •

edited

Loading