You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the dependency on source_node.uuid in the monitoring codebase. We want to move away from indexing this and this PR is the first step of the effort to shift our queries and response logic to look for and use this data elsewhere in the document.
Blockers
There are some metrics that rely on using the source_node.uuid to filter the data appropriately but the document type in which these metrics run doesn't have a 1-1 replacement for the uuid, notably metrics that rely on index_stats document types. Some document types (node_stats and shards) have a 1-1 replacement so those are fine.
The reason will be displayed to describe this comment to others. Learn more.
Pinging @ycombinator. Do we have a replacement plan for this? I can't remember from our earlier discussions, but are we able to inject the node's name (whatever node the beat is talking to) into the document shipped by MB? Or what was our plan for this?
@ycombinator and I synced about this and have decided to NOT pursue this effort. We're going to continue to rely on the source_node field as Metricbeat is currently still indexing it. We will take the time to remove this dependency once the UI is reading from Metricbeat indices.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #23720
STILL A WIP
This PR removes the dependency on
source_node.uuidin the monitoring codebase. We want to move away from indexing this and this PR is the first step of the effort to shift our queries and response logic to look for and use this data elsewhere in the document.Blockers
There are some metrics that rely on using the
source_node.uuidto filter the data appropriately but the document type in which these metrics run doesn't have a 1-1 replacement for the uuid, notably metrics that rely onindex_statsdocument types. Some document types (node_statsandshards) have a 1-1 replacement so those are fine.