Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Minimize reliance on source_node field #23720

Closed
ycombinator opened this issue Oct 2, 2018 · 4 comments
Closed

[Monitoring] Minimize reliance on source_node field #23720

ycombinator opened this issue Oct 2, 2018 · 4 comments
Labels
Team:Monitoring Stack Monitoring team

Comments

@ycombinator
Copy link
Contributor

Currently, when Elastic products send their monitoring data to the production Elasticsearch cluster, this cluster enriches the data with a source_node field. The intent of this field is to identify the ES node that received the monitoring data so that this information may be used during debugging.

However, the monitoring UI has come to inadvertently rely on this source_node field as well (that is, this field is not just being used for its original intent, debugging).

This problem will get worse once we move away from our products sending Monitoring to the production Elasticsearch cluster and towards Metricbeat monitoring our products instead. In the latter/future model, there will be notion of an Elasticsearch production cluster node receiving monitoring data so there will be no source_node either.

Therefore, we should audit the Monitoring UI codebase and remove/replace references to source_node as much as safely possible (while keeping backwards compatibility in mind).

@ycombinator
Copy link
Contributor Author

@chrisronline We should try and resolve this issue soon, as Metricbeat cannot populate the source_node field.

@ycombinator ycombinator added Team:Monitoring Stack Monitoring team and removed Team:Monitoring Stack Monitoring team chore labels Feb 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@chrisronline
Copy link
Contributor

@ycombinator Thanks for the bump. I'll revisit #23721 asap

@chrisronline
Copy link
Contributor

Closing as a result of a discussion: #23721 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Monitoring Stack Monitoring team
Projects
None yet
Development

No branches or pull requests

3 participants