Fixes #23179 #23183
Merged
Fixes #23179 #23183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue elastic#23179 was caused by ignoring multiple replicas of the same shard, even if they are on different nodes. This commit fixes that.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
As a note, this does not reintroduce #19704, since that issue resulted in the same replica being visible multiple times on the same node, which this PR still catches successfully. It just allows multiple copies of a replica to be on different nodes. |
|
Jenkins, test this |
|
@chrisronline Can you have a look into this PR? |
pickypg
approved these changes
Sep 14, 2018
💔 Build Failed |
|
Please test this |
|
(That's for our CI environment, not you; the first build failed because the server failed to start randomly) |
💚 Build Succeeded |
pickypg
pushed a commit
that referenced
this pull request
Sep 14, 2018
Issue #23179 was caused by ignoring multiple replicas of the same shard, even if they are on different nodes. This commit fixes that.
pickypg
pushed a commit
that referenced
this pull request
Sep 14, 2018
Issue #23179 was caused by ignoring multiple replicas of the same shard, even if they are on different nodes. This commit fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #23179 was caused by ignoring multiple replicas of the same shard, even if they are on different nodes. This commit fixes that.