Skip to content

Commit

Permalink
[Monitoring] Properly Deduplicate Replica shards (#23183)
Browse files Browse the repository at this point in the history
Issue #23179 was caused by ignoring multiple replicas of the same shard, even if they are on different nodes. This commit fixes that.
  • Loading branch information
programagor authored and pickypg committed Sep 14, 2018
1 parent 137bbb5 commit 529d7c4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function handleResponse(response) {

if (shard) {
// note: if the request is for a node, then it's enough to deduplicate without primary, but for indices it displays both
const shardId = `${shard.index}-${shard.shard}-${shard.primary}-${shard.relocating_node}`;
const shardId = `${shard.index}-${shard.shard}-${shard.primary}-${shard.relocating_node}-${shard.node}`;

if (!uniqueShards.has(shardId)) {
shards.push(shard);
Expand Down

0 comments on commit 529d7c4

Please sign in to comment.