Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrollbar in ie11 #21976

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Fix scrollbar in ie11 #21976

merged 2 commits into from
Aug 15, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Aug 15, 2018

Fixes #9649

Bootstrap had a MS specific viewport hack for windows mobile phones that did some goofy stuff with scrollbars. Removing it makes them work correctly in IE11.

after

image

before

image

@snide snide requested review from cchaos and marius-dr August 15, 2018 00:45
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed by checking IE11 before and after. The scrollbar properly works within the window.

@snide snide merged commit a72bd03 into elastic:master Aug 15, 2018
@snide snide deleted the ie/scrollfix branch August 15, 2018 18:15
snide added a commit to snide/kibana that referenced this pull request Aug 15, 2018
* fix scrollbar in ie11
snide added a commit that referenced this pull request Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants