Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eui 3.6.0 #21968

Merged
merged 4 commits into from
Aug 15, 2018
Merged

Eui 3.6.0 #21968

merged 4 commits into from
Aug 15, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 14, 2018

bump EUI to 3.6.0

This PR also removes CopyButton from the kibana/home application. This functionality was migrated to EUI.

@nreese nreese requested a review from jen-huang August 14, 2018 19:55
@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor Author

nreese commented Aug 14, 2018

Seen this failure in other PRs

fail: "logstash grok debugger app syntax highlighting applies the correct CSS classes"
21:04:42    │ proc  [ftr]        │        [GET http://localhost:9515/session/a81212e8d56f5c91c6af888fa8bceaef/element/0.12093181339829151-34/text] stale element reference: element is not attached to the page document

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally including the EUI copy button. LGTM!

@jen-huang
Copy link
Contributor

FYI the backport of this to 6.x may need to wait until #21964 is merged. There is a known CI failure on 6.x.

@jen-huang
Copy link
Contributor

jen-huang commented Aug 15, 2018

#21964 is merged so this is good to backport 😄

nreese added a commit to nreese/kibana that referenced this pull request Aug 15, 2018
* bump EUI to 3.6.0

* replace CopyButton with EuiCopy

* remove snapshot file from deleted CopyButton component
nreese added a commit that referenced this pull request Aug 15, 2018
* bump EUI to 3.6.0

* replace CopyButton with EuiCopy

* remove snapshot file from deleted CopyButton component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants