Eui 3.6.0 (#21968) (#22019)

* bump EUI to 3.6.0 * replace CopyButton with EuiCopy * remove snapshot file from deleted CopyButton component
elastic · Aug 15, 2018 · 182cf2f · 182cf2f
1 parent 2eb5e19
commit 182cf2f
Show file tree

Hide file tree

Showing 13 changed files with 39 additions and 204 deletions.
diff --git a/package.json b/package.json
@@ -75,7 +75,7 @@
     "url": "https://github.com/elastic/kibana.git"
   },
   "dependencies": {
-    "@elastic/eui": "3.4.0",
+    "@elastic/eui": "3.6.0",
     "@elastic/filesaver": "1.1.2",
     "@elastic/numeral": "2.3.2",
     "@elastic/ui-ace": "0.2.3",

diff --git a/...ore_plugins/kibana/public/home/components/tutorial/__snapshots__/copy_button.test.js.snap b/...ore_plugins/kibana/public/home/components/tutorial/__snapshots__/copy_button.test.js.snap
diff --git a/src/core_plugins/kibana/public/home/components/tutorial/copy_button.js b/src/core_plugins/kibana/public/home/components/tutorial/copy_button.js
diff --git a/src/core_plugins/kibana/public/home/components/tutorial/copy_button.test.js b/src/core_plugins/kibana/public/home/components/tutorial/copy_button.test.js
diff --git a/src/core_plugins/kibana/public/home/components/tutorial/instruction.js b/src/core_plugins/kibana/public/home/components/tutorial/instruction.js
@@ -20,13 +20,14 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import { Content } from './content';
-import { CopyButton } from './copy_button';
 
 import {
   EuiCodeBlock,
   EuiFlexGroup,
   EuiFlexItem,
   EuiSpacer,
+  EuiCopy,
+  EuiButton,
 } from '@elastic/eui';
 
 export function Instruction({ commands, paramValues, textPost, textPre, replaceTemplateStrings }) {
@@ -56,9 +57,18 @@ export function Instruction({ commands, paramValues, textPost, textPre, replaceT
   if (commands) {
     const cmdText = commands.map(cmd => { return replaceTemplateStrings(cmd, paramValues); }).join('\n');
     copyButton = (
-      <CopyButton
+      <EuiCopy
         textToCopy={cmdText}
-      />
+      >
+        {(copy) => (
+          <EuiButton
+            size="s"
+            onClick={copy}
+          >
+            Copy snippet
+          </EuiButton>
+        )}
+      </EuiCopy>
     );
     commandBlock = (
       <div>

diff --git a/src/core_plugins/kibana/public/home/copy_to_clipboard.js b/src/core_plugins/kibana/public/home/copy_to_clipboard.js
diff --git a/x-pack/package.json b/x-pack/package.json
@@ -79,7 +79,7 @@
     "yargs": "4.7.1"
   },
   "dependencies": {
-    "@elastic/eui": "3.4.0",
+    "@elastic/eui": "3.6.0",
     "@elastic/node-crypto": "0.1.2",
     "@elastic/node-phantom-simple": "2.2.4",
     "@elastic/numeral": "2.3.2",

diff --git a/x-pack/plugins/ml/public/components/rule_editor/__snapshots__/actions_section.test.js.snap b/x-pack/plugins/ml/public/components/rule_editor/__snapshots__/actions_section.test.js.snap
@@ -30,6 +30,7 @@ exports[`ActionsSection renders with no actions selected 1`] = `
         compressed={false}
         disabled={false}
         id="skip_result_cb"
+        indeterminate={false}
         label="Skip result (recommended)"
         onChange={[MockFunction]}
       />
@@ -68,6 +69,7 @@ exports[`ActionsSection renders with no actions selected 1`] = `
         compressed={false}
         disabled={false}
         id="skip_model_update_cb"
+        indeterminate={false}
         label="Skip model update"
         onChange={[MockFunction]}
       />
@@ -118,6 +120,7 @@ exports[`ActionsSection renders with skip_result and skip_model_update selected
         compressed={false}
         disabled={false}
         id="skip_result_cb"
+        indeterminate={false}
         label="Skip result (recommended)"
         onChange={[Function]}
       />
@@ -156,6 +159,7 @@ exports[`ActionsSection renders with skip_result and skip_model_update selected
         compressed={false}
         disabled={false}
         id="skip_model_update_cb"
+        indeterminate={false}
         label="Skip model update"
         onChange={[Function]}
       />
@@ -206,6 +210,7 @@ exports[`ActionsSection renders with skip_result selected 1`] = `
         compressed={false}
         disabled={false}
         id="skip_result_cb"
+        indeterminate={false}
         label="Skip result (recommended)"
         onChange={[MockFunction]}
       />
@@ -244,6 +249,7 @@ exports[`ActionsSection renders with skip_result selected 1`] = `
         compressed={false}
         disabled={false}
         id="skip_model_update_cb"
+        indeterminate={false}
         label="Skip model update"
         onChange={[MockFunction]}
       />

diff --git a/...ck/plugins/ml/public/components/rule_editor/__snapshots__/rule_editor_flyout.test.js.snap b/...ck/plugins/ml/public/components/rule_editor/__snapshots__/rule_editor_flyout.test.js.snap
@@ -133,6 +133,7 @@ exports[`RuleEditorFlyout renders the flyout after adding a condition to a rule
         compressed={false}
         disabled={true}
         id="enable_conditions_checkbox"
+        indeterminate={false}
         label="Add numeric conditions for when the rule applies. Multiple conditions are combined using AND."
         onChange={[Function]}
       />
@@ -367,6 +368,7 @@ exports[`RuleEditorFlyout renders the flyout after setting the rule to edit 1`]
         compressed={false}
         disabled={true}
         id="enable_conditions_checkbox"
+        indeterminate={false}
         label="Add numeric conditions for when the rule applies. Multiple conditions are combined using AND."
         onChange={[Function]}
       />
@@ -587,6 +589,7 @@ exports[`RuleEditorFlyout renders the flyout for creating a rule with conditions
         compressed={false}
         disabled={true}
         id="enable_conditions_checkbox"
+        indeterminate={false}
         label="Add numeric conditions for when the rule applies. Multiple conditions are combined using AND."
         onChange={[Function]}
       />

diff --git a/x-pack/plugins/ml/public/components/rule_editor/__snapshots__/scope_expression.test.js.snap b/x-pack/plugins/ml/public/components/rule_editor/__snapshots__/scope_expression.test.js.snap
@@ -20,6 +20,7 @@ exports[`ScopeExpression renders when empty list of filter IDs is supplied 1`] =
       compressed={false}
       disabled={false}
       id="scope_cb_domain"
+      indeterminate={false}
       onChange={[Function]}
     />
   </EuiFlexItem>
@@ -58,6 +59,7 @@ exports[`ScopeExpression renders when enabled set to false 1`] = `
       compressed={false}
       disabled={false}
       id="scope_cb_domain"
+      indeterminate={false}
       onChange={[Function]}
     />
   </EuiFlexItem>
@@ -211,6 +213,7 @@ exports[`ScopeExpression renders when filter ID and type supplied 1`] = `
       compressed={false}
       disabled={false}
       id="scope_cb_domain"
+      indeterminate={false}
       onChange={[Function]}
     />
   </EuiFlexItem>
@@ -364,6 +367,7 @@ exports[`ScopeExpression renders when no filter ID or type supplied 1`] = `
       compressed={false}
       disabled={false}
       id="scope_cb_domain"
+      indeterminate={false}
       onChange={[Function]}
     />
   </EuiFlexItem>

diff --git a/x-pack/plugins/ml/public/components/rule_editor/__snapshots__/scope_section.test.js.snap b/x-pack/plugins/ml/public/components/rule_editor/__snapshots__/scope_section.test.js.snap
@@ -19,6 +19,7 @@ exports[`ScopeSection false canGetFilters privilege show NoPermissionCallOut whe
     compressed={false}
     disabled={false}
     id="enable_scope_checkbox"
+    indeterminate={false}
     label="Add a filter list to limit where the rule applies."
     onChange={[MockFunction]}
   />
@@ -51,6 +52,7 @@ exports[`ScopeSection renders when enabled with no scope supplied 1`] = `
     compressed={false}
     disabled={false}
     id="enable_scope_checkbox"
+    indeterminate={false}
     label="Add a filter list to limit where the rule applies."
     onChange={[MockFunction]}
   />
@@ -97,6 +99,7 @@ exports[`ScopeSection renders when enabled with scope supplied 1`] = `
     compressed={false}
     disabled={false}
     id="enable_scope_checkbox"
+    indeterminate={false}
     label="Add a filter list to limit where the rule applies."
     onChange={[MockFunction]}
   />
@@ -143,6 +146,7 @@ exports[`ScopeSection renders when not enabled 1`] = `
     compressed={false}
     disabled={false}
     id="enable_scope_checkbox"
+    indeterminate={false}
     label="Add a filter list to limit where the rule applies."
     onChange={[MockFunction]}
   />
@@ -172,6 +176,7 @@ exports[`ScopeSection show NoFilterListsCallOut when no filter list IDs 1`] = `
     compressed={false}
     disabled={false}
     id="enable_scope_checkbox"
+    indeterminate={false}
     label="Add a filter list to limit where the rule applies."
     onChange={[MockFunction]}
   />