Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE centering issue in dashboard list #21841

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Fix IE centering issue in dashboard list #21841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ...core_plugins/kibana/public/dashboard/listing/__snapshots__/dashboard_listing.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ exports[`after fetch hideWriteControls 1`] = `
<EuiPage
className="dashboardLandingPage"
data-test-subj="dashboardLandingPage"
restrictWidth={false}
restrictWidth={true}
>
<EuiPageBody
restrictWidth={true}
restrictWidth={false}
>
<EuiPageContent
horizontalPosition="center"
Expand All @@ -34,10 +34,10 @@ exports[`after fetch initialFilter 1`] = `
<EuiPage
className="dashboardLandingPage"
data-test-subj="dashboardLandingPage"
restrictWidth={false}
restrictWidth={true}
>
<EuiPageBody
restrictWidth={true}
restrictWidth={false}
>
<EuiPageContent
horizontalPosition="center"
Expand Down Expand Up @@ -186,10 +186,10 @@ exports[`after fetch renders call to action when no dashboards exist 1`] = `
<EuiPage
className="dashboardLandingPage"
data-test-subj="dashboardLandingPage"
restrictWidth={false}
restrictWidth={true}
>
<EuiPageBody
restrictWidth={true}
restrictWidth={false}
>
<EuiPageContent
horizontalPosition="center"
Expand Down Expand Up @@ -246,10 +246,10 @@ exports[`after fetch renders table rows 1`] = `
<EuiPage
className="dashboardLandingPage"
data-test-subj="dashboardLandingPage"
restrictWidth={false}
restrictWidth={true}
>
<EuiPageBody
restrictWidth={true}
restrictWidth={false}
>
<EuiPageContent
horizontalPosition="center"
Expand Down Expand Up @@ -398,10 +398,10 @@ exports[`after fetch renders warning when listingLimit is exceeded 1`] = `
<EuiPage
className="dashboardLandingPage"
data-test-subj="dashboardLandingPage"
restrictWidth={false}
restrictWidth={true}
>
<EuiPageBody
restrictWidth={true}
restrictWidth={false}
>
<EuiPageContent
horizontalPosition="center"
Expand Down Expand Up @@ -581,10 +581,10 @@ exports[`renders empty page in before initial fetch to avoid flickering 1`] = `
<EuiPage
className="dashboardLandingPage"
data-test-subj="dashboardLandingPage"
restrictWidth={false}
restrictWidth={true}
>
<EuiPageBody
restrictWidth={true}
restrictWidth={false}
/>
</EuiPage>
`;
4 changes: 2 additions & 2 deletions src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,8 @@ export class DashboardListing extends React.Component {

render() {
return (
<EuiPage data-test-subj="dashboardLandingPage" className="dashboardLandingPage">
<EuiPageBody restrictWidth>
<EuiPage data-test-subj="dashboardLandingPage" className="dashboardLandingPage" restrictWidth>
<EuiPageBody>
{this.renderPageContent()}
</EuiPageBody>
</EuiPage>
Expand Down