Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE centering issue in dashboard list #21841

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Conversation

snide
Copy link
Contributor

@snide snide commented Aug 9, 2018

IE has trouble with the restrictwidth being on the content rather than the page itself. This sets it straight.

cc @LeeDr

@snide snide requested a review from nreese August 9, 2018 15:18
@LeeDr LeeDr added the v6.5.0 label Aug 9, 2018
@LeeDr
Copy link

LeeDr commented Aug 9, 2018

@snide I added v6.5.0 label because I'm thinking you would also merge to 6.x branch (which is v6.5.0). But take it off if that's wrong.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review, still looks good in Chrome

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide snide merged commit 6af72b7 into elastic:master Aug 9, 2018
@snide snide deleted the ie/dashlist branch August 9, 2018 17:19
@snide
Copy link
Contributor Author

snide commented Aug 9, 2018

@LeeDr yep, ty, ill backport it there now as well.

snide added a commit to snide/kibana that referenced this pull request Aug 9, 2018
Fixes a display regression with internet explorer.
snide added a commit to snide/kibana that referenced this pull request Aug 9, 2018
Fixes a display regression with internet explorer.
Conflicts:
	src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js
snide added a commit that referenced this pull request Aug 9, 2018
Fixes a display regression with internet explorer.
epixa added a commit to epixa/kibana that referenced this pull request Aug 10, 2018
snide added a commit that referenced this pull request Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants