[build] clean @types from distributions #21565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
tylersmalley
approved these changes
Aug 14, 2018
There was a problem hiding this comment.
LGTM
node_modules/@slack/client/node_modules/@types
node_modules/@types
node_modules/@types/execa/node_modules/@types
node_modules/@types/form-data/node_modules/@types
node_modules/@types/glob/node_modules/@types
node_modules/@types/got/node_modules/@types
node_modules/@types/hapi-latest/node_modules/@types
node_modules/@types/iron/node_modules/@types
node_modules/@types/is-stream/node_modules/@types
node_modules/@types/listr/node_modules/@types
node_modules/@types/react-dom/node_modules/@types
node_modules/@types/shot/node_modules/@types
node_modules/@types/superagent/node_modules/@types
node_modules/@types/ws/node_modules/@types
node_modules/enzyme/node_modules/@types
|
I am not sure how many files this covers as we already get rid of the ts files and markdown which appears to be what these directories mostly contain, but it should hurt. |
💚 Build Succeeded |
jbudz
added a commit
that referenced
this pull request
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes typescript definitions from our final build. No need for them in a non development environment.
Closes #20296