Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing @types/* packages from the build's node_modules folder #20296

Closed
azasypkin opened this issue Jun 28, 2018 · 0 comments
Closed
Labels
build Team:Operations Team label for Operations Team

Comments

@azasypkin
Copy link
Member

Currently some packages we depend on declare @types/* as "normal" dependencies (e.g. @slack/client) so they are included into our build packages (license file, package.json and readme file for every such package).

I can't think of any reason why we'd want to have these packages included into build, so should we just add @types/* into CleanExtraFilesFromModulesTask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

1 participant