-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Enable syntax highlighting for ES|QL #212669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
c0a128c
to
550674a
Compare
neptunian
approved these changes
Feb 28, 2025
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13588602077 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 28, 2025
Closes elastic#212384 ## Summary With elastic/eui#8317, `EuiCodeBlock` supports syntax highlighting for ES|QL. This PR enables it for Obs AI Assistant ### Screenshots Before:  After:  ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 6d862d7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
7 tasks
kibanamachine
added a commit
that referenced
this pull request
Feb 28, 2025
… (#212765) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Enable syntax highlighting for ES|QL (#212669)](#212669) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-28T12:56:18Z","message":"[Obs AI Assistant] Enable syntax highlighting for ES|QL (#212669)\n\nCloses https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith elastic/eui#8317, `EuiCodeBlock` supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI Assistant\n\n### Screenshots\n\nBefore:\n\n\nAfter:\n\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Obs AI Assistant","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI Assistant] Enable syntax highlighting for ES|QL","number":212669,"url":"https://github.com/elastic/kibana/pull/212669","mergeCommit":{"message":"[Obs AI Assistant] Enable syntax highlighting for ES|QL (#212669)\n\nCloses https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith elastic/eui#8317, `EuiCodeBlock` supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI Assistant\n\n### Screenshots\n\nBefore:\n\n\nAfter:\n\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212669","number":212669,"mergeCommit":{"message":"[Obs AI Assistant] Enable syntax highlighting for ES|QL (#212669)\n\nCloses https://github.com/elastic/kibana/issues/212384\n\n## Summary\n\nWith elastic/eui#8317, `EuiCodeBlock` supports\nsyntax highlighting for ES|QL.\nThis PR enables it for Obs AI Assistant\n\n### Screenshots\n\nBefore:\n\n\nAfter:\n\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6d862d72a2358438c5e1295ca004f59cc7115170"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:enhancement
Team:Obs AI Assistant
Observability AI Assistant
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212384
Summary
With elastic/eui#8317,
EuiCodeBlock
supports syntax highlighting for ES|QL.This PR enables it for Obs AI Assistant
Screenshots
Before:

After:

Checklist
release_note:*
label is applied per the guidelines