-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automatic Import] Fixes the CSV header bug #212513
[Automatic Import] Fixes the CSV header bug #212513
Conversation
…m:ilyannn/kibana into auto-import/fix/csv-mapping-timestamp-bug
💔 Build Failed
Failed CI StepsHistorycc @ilyannn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good one
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/13590247953 |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Release Note
Automatic Import now produces correct pipeline to parse CSV files with special characters in column names.
Summary
Fixes #211911
Now the pipeline works as expected:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesDetails
The CSV processing is now a three-stage process:
column1
.package.dataStream.columnName
.{"columnName": "value", ...}
for further processing.Tests
There are unit tests tests for the CSV functionality that include a mock CSV processing pipeline.