Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added performance telemetry to profiling pages #208832

Merged
merged 18 commits into from
Feb 10, 2025
Merged

added performance telemetry to profiling pages #208832

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7770ba0
added performance telemetry to profiling pages
bryce-b Jan 29, 2025
fca5a70
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine Jan 29, 2025
c9d8c60
Update x-pack/solutions/observability/plugins/profiling/public/views/…
bryce-b Jan 30, 2025
f285986
Update x-pack/solutions/observability/plugins/profiling/public/views/…
bryce-b Jan 30, 2025
397831f
updating isLoading checks to use Settled status
bryce-b Jan 31, 2025
faac527
added PerformanceContextProvider
bryce-b Jan 31, 2025
a5c2395
Merge branch 'main' into 205393_Profiling_Perf_Tests
bryce-b Jan 31, 2025
96d3404
Merge branch 'main' into 205393_Profiling_Perf_Tests
bryce-b Feb 3, 2025
bec57d4
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine Feb 4, 2025
2ca12eb
adds telemetry to profiling storage explorer
bryce-b Feb 4, 2025
5a847bd
Merge branch 'main' into 205393_Profiling_Perf_Tests
bryce-b Feb 4, 2025
2610243
included host_breakdown call for onPageReady telemetry
bryce-b Feb 5, 2025
144e01d
Merge branch 'main' into 205393_Profiling_Perf_Tests
bryce-b Feb 5, 2025
089aa12
wrapped calls to onPageReady with useEffect
bryce-b Feb 6, 2025
b41b832
added states for storage explorer loading
bryce-b Feb 6, 2025
54bee92
narrowed useEffect dependecy lists
bryce-b Feb 7, 2025
c94bd37
Merge branch 'main' into 205393_Profiling_Perf_Tests
bryce-b Feb 7, 2025
01c3ee4
Merge branch 'main' into 205393_Profiling_Perf_Tests
bryce-b Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...servability/plugins/profiling/public/views/flamegraphs/differential_flamegraphs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
*/
import { EuiFlexGroup, EuiFlexItem, EuiPanel, EuiSpacer } from '@elastic/eui';
import React from 'react';
import { usePerformanceContext } from '@kbn/ebt-tools';

import { profilingShowErrorFrames } from '@kbn/observability-plugin/common';
import { AsyncComponent } from '../../../components/async_component';
import { useProfilingDependencies } from '../../../components/contexts/profiling_dependencies/use_profiling_dependencies';
Expand Down Expand Up @@ -119,6 +121,21 @@ export function DifferentialFlameGraphsView() {
profilingRouter.push(routePath, { query: { ...query, searchText: newSearchText } });
}

const { onPageReady } = usePerformanceContext();

if (state.status !== AsyncStatus.Loading) {
bryce-b marked this conversation as resolved.
Show resolved Hide resolved
onPageReady({
meta: {
rangeFrom,
rangeTo,
},
customMetrics: {
key1: 'totalSamples',
value1: state.data?.primaryFlamegraph.TotalSamples ?? 0,
},
});
}

return (
<EuiFlexGroup direction="column">
<EuiFlexItem grow={false}>
Expand Down
17 changes: 17 additions & 0 deletions ...k/solutions/observability/plugins/profiling/public/views/flamegraphs/flamegraph/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
import React from 'react';
import { profilingShowErrorFrames } from '@kbn/observability-plugin/common';
import { usePerformanceContext } from '@kbn/ebt-tools';
import { AsyncComponent } from '../../../components/async_component';
import { useProfilingDependencies } from '../../../components/contexts/profiling_dependencies/use_profiling_dependencies';
import { FlameGraph } from '../../../components/flamegraph';
Expand All @@ -15,6 +16,7 @@ import { useProfilingRoutePath } from '../../../hooks/use_profiling_route_path';
import { useProfilingRouter } from '../../../hooks/use_profiling_router';
import { useTimeRange } from '../../../hooks/use_time_range';
import { useTimeRangeAsync } from '../../../hooks/use_time_range_async';
import { AsyncStatus } from '../../../hooks/use_async';

export function FlameGraphView() {
const {
Expand Down Expand Up @@ -55,6 +57,21 @@ export function FlameGraphView() {
profilingRouter.push(routePath, { query: { ...query, searchText: newSearchText } });
}

const { onPageReady } = usePerformanceContext();

if (state.status !== AsyncStatus.Loading) {
onPageReady({
meta: {
rangeFrom,
rangeTo,
},
customMetrics: {
key1: 'totalSamples',
value1: state.data?.TotalSamples ?? 0,
},
});
}

return (
<EuiFlexGroup direction="column">
<EuiFlexItem>
Expand Down
24 changes: 20 additions & 4 deletions ...utions/observability/plugins/profiling/public/views/functions/differential_topn/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/
import { EuiFlexGroup, EuiFlexItem, EuiHorizontalRule, EuiPanel, EuiSpacer } from '@elastic/eui';
import React from 'react';
import { usePerformanceContext } from '@kbn/ebt-tools';
import { AsyncComponent } from '../../../components/async_component';
import { useProfilingDependencies } from '../../../components/contexts/profiling_dependencies/use_profiling_dependencies';
import { FramesSummary } from '../../../components/frames_summary';
Expand All @@ -22,6 +23,7 @@ import { useTimeRange } from '../../../hooks/use_time_range';
import { useTimeRangeAsync } from '../../../hooks/use_time_range_async';

export function DifferentialTopNFunctionsView() {
const { onPageReady } = usePerformanceContext();
const { query } = useProfilingParams('/functions/differential');
const {
rangeFrom,
Expand Down Expand Up @@ -147,6 +149,23 @@ export function DifferentialTopNFunctionsView() {
});
}

function isLoading() {
return state.status === AsyncStatus.Loading || comparisonState.status === AsyncStatus.Loading;
}

if (!isLoading()) {
onPageReady({
meta: {
rangeFrom,
rangeTo,
},
customMetrics: {
key1: 'TotalCount',
bryce-b marked this conversation as resolved.
Show resolved Hide resolved
value1: state.data?.TotalCount ?? 0,
},
});
}

return (
<>
<EuiFlexGroup direction="column">
Expand All @@ -161,10 +180,7 @@ export function DifferentialTopNFunctionsView() {
/>
<EuiSpacer />
<FramesSummary
isLoading={
state.status === AsyncStatus.Loading ||
comparisonState.status === AsyncStatus.Loading
}
isLoading={isLoading()}
baseValue={
state.data
? {
Expand Down
16 changes: 16 additions & 0 deletions x-pack/solutions/observability/plugins/profiling/public/views/functions/topn/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import type { EuiDataGridSorting } from '@elastic/eui';
import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
import React from 'react';
import { usePerformanceContext } from '@kbn/ebt-tools';
import type { TopNFunctionSortField } from '@kbn/profiling-utils';
import { AsyncComponent } from '../../../components/async_component';
import { useProfilingDependencies } from '../../../components/contexts/profiling_dependencies/use_profiling_dependencies';
Expand All @@ -15,8 +16,10 @@ import { useProfilingParams } from '../../../hooks/use_profiling_params';
import { useProfilingRouter } from '../../../hooks/use_profiling_router';
import { useTimeRange } from '../../../hooks/use_time_range';
import { useTimeRangeAsync } from '../../../hooks/use_time_range_async';
import { AsyncStatus } from '../../../hooks/use_async';

export function TopNFunctionsView() {
const { onPageReady } = usePerformanceContext();
const { query } = useProfilingParams('/functions/topn');
const { rangeFrom, rangeTo, kuery, sortDirection, sortField, pageIndex = 0 } = query;

Expand Down Expand Up @@ -67,6 +70,19 @@ export function TopNFunctionsView() {
});
}

if (state.status !== AsyncStatus.Loading) {
onPageReady({
meta: {
rangeFrom,
rangeTo,
},
customMetrics: {
key1: 'TotalCount',
bryce-b marked this conversation as resolved.
Show resolved Hide resolved
value1: state.data?.TotalCount ?? 0,
},
});
}

return (
<>
<EuiFlexGroup direction="column">
Expand Down
17 changes: 17 additions & 0 deletions x-pack/solutions/observability/plugins/profiling/public/views/stack_traces_view/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* 2.0.
*/
import React from 'react';
import { usePerformanceContext } from '@kbn/ebt-tools';
import { groupSamplesByCategory } from '../../../common/topn';
import { useProfilingDependencies } from '../../components/contexts/profiling_dependencies/use_profiling_dependencies';
import { ProfilingAppPageTemplate } from '../../components/profiling_app_page_template';
Expand All @@ -17,6 +18,7 @@ import { useTimeRangeAsync } from '../../hooks/use_time_range_async';
import { RouteBreadcrumb } from '../../routing/route_breadcrumb';
import { getStackTracesTabs } from './get_stack_traces_tabs';
import { getTracesViewRouteParams } from './utils';
import { AsyncStatus } from '../../hooks/use_async';

export function StackTracesView() {
const routePath = useProfilingRoutePath();
Expand Down Expand Up @@ -71,6 +73,21 @@ export function StackTracesView() {
);
}

const { onPageReady } = usePerformanceContext();

if (state.status !== AsyncStatus.Loading) {
onPageReady({
meta: {
rangeFrom,
rangeTo,
},
customMetrics: {
key1: 'totalCount',
value1: state.data?.charts.length ?? 0,
},
});
}

return (
<RouteBreadcrumb title={selectedTab?.label || ''} href={selectedTab?.href || ''}>
<ProfilingAppPageTemplate tabs={tabs}>
Expand Down
3 changes: 2 additions & 1 deletion x-pack/solutions/observability/plugins/profiling/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@
"@kbn/deeplinks-observability",
"@kbn/react-kibana-context-render",
"@kbn/apm-data-access-plugin",
"@kbn/security-plugin-types-server"
"@kbn/security-plugin-types-server",
"@kbn/ebt-tools"
// add references to other TypeScript projects the plugin depends on

// requiredPlugins from ./kibana.json
Expand Down