Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added performance telemetry to profiling pages #208832

Merged
merged 18 commits into from
Feb 10, 2025
Merged

Conversation

bryce-b
Copy link
Contributor

@bryce-b bryce-b commented Jan 29, 2025

Summary

This adds performance telemetry to the profiling pages listed in #205393

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Sorry, something went wrong.

@bryce-b bryce-b added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 29, 2025
@bryce-b
Copy link
Contributor Author

bryce-b commented Jan 29, 2025

I'm going to publish this pr to see if I can get the cloud instance to build.

@bryce-b bryce-b marked this pull request as ready for review January 29, 2025 22:38
@bryce-b bryce-b requested a review from a team as a code owner January 29, 2025 22:38
@bryce-b bryce-b added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment and removed ci:build-cloud-image labels Jan 29, 2025
@bryce-b
Copy link
Contributor Author

bryce-b commented Jan 29, 2025

/oblt-deploy

bryce-b and others added 2 commits January 30, 2025 07:44
…functions/topn/index.tsx

Co-authored-by: Carlos Crespo <[email protected]>
…functions/differential_topn/index.tsx

Co-authored-by: Carlos Crespo <[email protected]>
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Universal Profiling pages are crashing. I'm seeing this error:

image

We need to wrap the routes with the on here https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/profiling/public/app.tsx

@bryce-b
Copy link
Contributor Author

bryce-b commented Jan 31, 2025

/oblt-deploy

@bryce-b bryce-b enabled auto-merge (squash) February 3, 2025 23:55
@bryce-b bryce-b requested a review from crespocarlos February 3, 2025 23:55
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shouldn't we track the storage explorer page too?

bryce-b and others added 2 commits February 4, 2025 10:01
@bryce-b bryce-b requested a review from cauemarcondes February 4, 2025 18:06
Comment on lines 70 to 75
onPageReady({
meta: {
rangeFrom,
rangeTo,
},
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the page will be ready when storageExplorerSummaryState is complete and the default open tab content also finishes loading. In this case, host_breakdown. Wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I agree. I'll add a status check for the host breakdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the onPageReady call into the host_breakdown component. I'm not super jazzed about it, but pulling the host_breakdown fetch into the storage_explorer looked like a mess due to the tab state changes. One issue with this solution is the onPageReady will be called every time the tab is toggled, I tried wrapping the call in a useMemo, but it looks like the api-call is also refreshed, so it seems like more of an issue with the component itself. Is this due to the fact the time window is technically changed from the last fetch? Is this ok to leave alone?
Do you think this solution is alright, or do you have an alternative suggestion?
If this looks ok, then it might be worthwhile to add telemetry to the data breakdown tab as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Bryce, thanks for the changes. I think it's fine to call onPageReady more than once. It will only register one event per page view: https://github.com/crespocarlos/kibana/blob/main/src/platform/packages/shared/kbn-ebt-tools/src/performance_metrics/context/use_page_ready.ts

You could also test this by following this comment and checking on Discover whether the event is registered on every tab switch.

Should new events be registered when switching tabs, we'll need to see what we can do.

@bryce-b bryce-b requested a review from crespocarlos February 7, 2025 00:02
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes so far @bryce-b . Left a few comments, but It's almost there.

bryce-b and others added 2 commits February 7, 2025 09:02
@bryce-b bryce-b requested a review from crespocarlos February 7, 2025 17:36
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Did you manage to create a dashboard on the staging env https://telemetry-v2-staging.elastic.dev/?

@bryce-b
Copy link
Contributor Author

bryce-b commented Feb 10, 2025

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

History

@bryce-b bryce-b merged commit f764e99 into main Feb 10, 2025
9 checks passed
@bryce-b bryce-b deleted the 205393_Profiling_Perf_Tests branch February 10, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-cloud-image ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants