Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Automatic Import] Reuse regex pattern to validate names (#205029) #205372

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[8.x] [Automatic Import] Reuse regex pattern to validate names (#205029) #205372

merged 1 commit into from
Jan 2, 2025

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Jan 2, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@bhapas
[Automatic Import] Reuse regex pattern to validate names (elastic#205029
180f369 
)

## Summary

This PR reuses the regex pattern to validate the names in UI and backend
created in elastic#204943

---------

Co-authored-by: Ilya Nikokoshev <[email protected]>
(cherry picked from commit b4417c6)

# Conflicts:
#	x-pack/platform/plugins/shared/integration_assistant/server/integration_builder/build_integration.ts
@bhapas bhapas requested a review from kibanamachine as a code owner January 2, 2025 11:03
@bhapas bhapas added the backport label Jan 2, 2025
@bhapas bhapas enabled auto-merge (squash) January 2, 2025 11:03
@bhapas bhapas self-assigned this Jan 2, 2025
@bhapas bhapas mentioned this pull request Jan 2, 2025
Merged
@bhapas bhapas merged commit 61982ac into elastic:8.x Jan 2, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 877.6KB 877.6KB +6.0B

cc @bhapas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haetamoudi haetamoudi haetamoudi approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

@bhapas bhapas

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhapas @elasticmachine @haetamoudi