Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automatic Import] Reuse regex pattern to validate names #205029

Merged
merged 4 commits into from
Dec 27, 2024
Merged

[Automatic Import] Reuse regex pattern to validate names #205029

merged 4 commits into from
Dec 27, 2024

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Dec 20, 2024 •
edited by kibanamachine
Loading

Summary

This PR reuses the regex pattern to validate the names in UI and backend created in #204943

@bhapas bhapas added release_note:skip Skip the PR/issue when compiling release notes backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Team:Security-Scalability Team label for Security Integrations Scalability Team Feature:AutomaticImport labels Dec 20, 2024
@bhapas bhapas self-assigned this Dec 20, 2024
@bhapas bhapas requested a review from a team as a code owner December 20, 2024 05:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@bhapas bhapas mentioned this pull request Dec 20, 2024
Merged
2 tasks
ilyannn
ilyannn approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ilyannn ilyannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though in the future perhaps we could reuse this pattern from somewhere else in Kibana.

@ilyannn ilyannn enabled auto-merge (squash) December 27, 2024 16:10
@ilyannn ilyannn merged commit b4417c6 into elastic:main Dec 27, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12518987825

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 880.8KB 880.8KB +6.0B

History

cc @bhapas

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.16 Backport failed because of merge conflicts
❌ 8.17 Backport failed because of merge conflicts
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 205029

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 30, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205029 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205029 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205029 locally

stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
@bhapas @ilyannn @stratoula
[Automatic Import] Reuse regex pattern to validate names (elastic#205029
0899923 
)

## Summary

This PR reuses the regex pattern to validate the names in UI and backend
created in elastic#204943

---------

Co-authored-by: Ilya Nikokoshev <[email protected]>
bhapas added a commit to bhapas/kibana that referenced this pull request Jan 2, 2025
@bhapas
[Automatic Import] Reuse regex pattern to validate names (elastic#205029
f4c1d27 
)

## Summary

This PR reuses the regex pattern to validate the names in UI and backend
created in elastic#204943

---------

Co-authored-by: Ilya Nikokoshev <[email protected]>
(cherry picked from commit b4417c6)

# Conflicts:
#	x-pack/plugins/integration_assistant/server/integration_builder/build_integration.ts
@bhapas bhapas mentioned this pull request Jan 2, 2025
Merged
@bhapas
Copy link
Contributor Author

bhapas commented Jan 2, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.x An unhandled error occurred. Please see the logs for details
❌ 8.17 An unhandled error occurred. Please see the logs for details
✅ 8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 205029

Questions ?

Please refer to the Backport tool documentation

@bhapas bhapas mentioned this pull request Jan 2, 2025
Merged
bhapas added a commit to bhapas/kibana that referenced this pull request Jan 2, 2025
@bhapas
[Automatic Import] Reuse regex pattern to validate names (elastic#205029
180f369 
)

## Summary

This PR reuses the regex pattern to validate the names in UI and backend
created in elastic#204943

---------

Co-authored-by: Ilya Nikokoshev <[email protected]>
(cherry picked from commit b4417c6)

# Conflicts:
#	x-pack/platform/plugins/shared/integration_assistant/server/integration_builder/build_integration.ts
bhapas added a commit to bhapas/kibana that referenced this pull request Jan 2, 2025
@bhapas
[Automatic Import] Reuse regex pattern to validate names (elastic#205029
566fa36 
)

## Summary

This PR reuses the regex pattern to validate the names in UI and backend
created in elastic#204943

---------

Co-authored-by: Ilya Nikokoshev <[email protected]>
(cherry picked from commit b4417c6)

# Conflicts:
#	x-pack/plugins/integration_assistant/server/integration_builder/build_integration.ts
@bhapas bhapas mentioned this pull request Jan 2, 2025
Merged
@bhapas
Copy link
Contributor Author

bhapas commented Jan 2, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@bhapas @ilyannn @benakansara
[Automatic Import] Reuse regex pattern to validate names (elastic#205029
c03b222 
)

## Summary

This PR reuses the regex pattern to validate the names in UI and backend
created in elastic#204943

---------

Co-authored-by: Ilya Nikokoshev <[email protected]>
bhapas added a commit that referenced this pull request Jan 2, 2025
@bhapas
[8.16] [Automatic Import] Reuse regex pattern to validate names (#205029
831a6ab 
) (#205369)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Automatic Import] Reuse regex pattern to validate names
(#205029)](#205029)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bharat
Pasupula","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-27T17:39:10Z","message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"number":205029,"url":"https://github.com/elastic/kibana/pull/205029","mergeCommit":{"message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205029","number":205029,"mergeCommit":{"message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb"}}]}]
BACKPORT-->
bhapas added a commit that referenced this pull request Jan 2, 2025
@bhapas
[8.x] [Automatic Import] Reuse regex pattern to validate names (#205029…
61982ac 
…) (#205372)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Automatic Import] Reuse regex pattern to validate names
(#205029)](#205029)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bharat
Pasupula","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-27T17:39:10Z","message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"number":205029,"url":"https://github.com/elastic/kibana/pull/205029","mergeCommit":{"message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205029","number":205029,"mergeCommit":{"message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb"}},{"url":"https://github.com/elastic/kibana/pull/205369","number":205369,"branch":"8.16","state":"OPEN"}]}]
BACKPORT-->
bhapas added a commit that referenced this pull request Jan 2, 2025
@bhapas @kibanamachine
[8.17] [Automatic Import] Reuse regex pattern to validate names (#205029
63f690e 
) (#205373)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Automatic Import] Reuse regex pattern to validate names
(#205029)](#205029)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bharat
Pasupula","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-27T17:39:10Z","message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"number":205029,"url":"https://github.com/elastic/kibana/pull/205029","mergeCommit":{"message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205029","number":205029,"mergeCommit":{"message":"[Automatic
Import] Reuse regex pattern to validate names (#205029)\n\n##
Summary\r\n\r\nThis PR reuses the regex pattern to validate the names in
UI and backend\r\ncreated in
https://github.com/elastic/kibana/pull/204943\r\n\r\n---------\r\n\r\nCo-authored-by:
Ilya Nikokoshev
<[email protected]>","sha":"b4417c695722eadc14a6304171ca2d9ec90064bb"}},{"url":"https://github.com/elastic/kibana/pull/205369","number":205369,"branch":"8.16","state":"OPEN"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine added v8.17.1 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 2, 2025
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
@bhapas @ilyannn @cqliu1
[Automatic Import] Reuse regex pattern to validate names (elastic#205029
9f68336 
)

## Summary

This PR reuses the regex pattern to validate the names in UI and backend
created in elastic#204943

---------

Co-authored-by: Ilya Nikokoshev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyannn ilyannn ilyannn approved these changes

Assignees

@bhapas bhapas

Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Feature:AutomaticImport release_note:skip Skip the PR/issue when compiling release notes Team:Security-Scalability Team label for Security Integrations Scalability Team v8.16.3 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhapas @elasticmachine @kibanamachine @ilyannn