Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Ownership] Print owner match also, not just owner (#202704) #204926

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[8.x] [Ownership] Print owner match also, not just owner (#202704) #204926

merged 2 commits into from
Dec 19, 2024

Conversation

wayneseymour
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@wayneseymour wayneseymour enabled auto-merge (squash) December 19, 2024 11:56
@wayneseymour wayneseymour mentioned this pull request Dec 19, 2024
Merged
auto-merge was automatically disabled December 19, 2024 12:48

Pull request was closed

@wayneseymour wayneseymour reopened this Dec 19, 2024
@wayneseymour
[Ownership] Print owner match also, not just owner (elastic#202704)
4ac5fbc 
Resolves: elastic#202666

To see the change, run this:
`node scripts/get_owners_for_file.js --file
test/functional/apps/console/_autocomplete.ts`

```
 succ elastic/kibana-management
```

```
 succ Found matching entry in .github/CODEOWNERS:
      test/functional/apps/console/*.ts elastic/kibana-management
```

---------

Co-authored-by: Robert Oskamp <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: David Olaru <[email protected]>
(cherry picked from commit e706b66)
@wayneseymour
ts fixup
e902dab
@wayneseymour wayneseymour force-pushed the backport/8.x/pr-202704 branch from a3c5c22 to e902dab Compare December 19, 2024 12:57
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/code-owners 4 5 +1
Unknown metric groups

API count

id before after diff
@kbn/code-owners 8 10 +2

History

@wayneseymour wayneseymour merged commit 4393cb2 into elastic:8.x Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wayneseymour @elasticmachine @dmlemeshko