Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Remove "userAndRoles" from es and security nav tree #204740

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Dec 18, 2024

In this PR I've removed the "User and roles" link in the footer side nav of the "search" and "security" solution (only in serverless).

I didn't remove it in the observability solution side nav because I didn't see the "Manage organization members" card in the management home page.

Fixes #192501

Screenshots

Search (card present)

Screenshot 2024-12-18 at 12 14 05

Observability (card not present)

Screenshot 2024-12-18 at 12 12 05

@sebelga sebelga self-assigned this Dec 18, 2024
@sebelga sebelga added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Serverless Work as part of the Serverless project for its initial release Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) labels Dec 18, 2024
@sebelga
Copy link
Contributor Author

sebelga commented Dec 18, 2024

/ci

@sebelga
Copy link
Contributor Author

sebelga commented Dec 18, 2024

/ci

@sebelga
Copy link
Contributor Author

sebelga commented Dec 18, 2024

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 26.4KB 26.4KB -43.0B
serverlessSearch 22.9KB 22.9KB -54.0B
total -97.0B

History

cc @sebelga

@sebelga sebelga marked this pull request as ready for review December 18, 2024 17:56
@sebelga sebelga requested review from a team as code owners December 18, 2024 17:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebelga sebelga merged commit 6f28942 into elastic:main Dec 19, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12413066140

@sebelga sebelga deleted the serverless-chrome/remove-user-roles branch December 19, 2024 12:53
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 19, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2024
…ty nav tree (#204740) (#204932)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Serverless] Remove "userAndRoles" from es and security nav
tree (#204740)](#204740)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sébastien
Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T12:52:35Z","message":"[Serverless]
Remove \"userAndRoles\" from es and security nav tree
(#204740)","sha":"6f28942e1ece04051c8e3d031b02ef185e81fc89","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Project:Serverless","Feature:Chrome"],"title":"[Serverless]
Remove \"userAndRoles\" from es and security nav
tree","number":204740,"url":"https://github.com/elastic/kibana/pull/204740","mergeCommit":{"message":"[Serverless]
Remove \"userAndRoles\" from es and security nav tree
(#204740)","sha":"6f28942e1ece04051c8e3d031b02ef185e81fc89"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204740","number":204740,"mergeCommit":{"message":"[Serverless]
Remove \"userAndRoles\" from es and security nav tree
(#204740)","sha":"6f28942e1ece04051c8e3d031b02ef185e81fc89"}}]}]
BACKPORT-->

Co-authored-by: Sébastien Loix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SideNav][Serverless] Remove "Project Settings\Users and roles" Menu Item
5 participants