Skip to content

Commit

Permalink
[8.x] [Serverless] Remove "userAndRoles" from es and securi…
Browse files Browse the repository at this point in the history
…ty nav tree (#204740) (#204932)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Serverless] Remove "userAndRoles" from es and security nav
tree (#204740)](#204740)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sébastien
Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T12:52:35Z","message":"[Serverless]
Remove \"userAndRoles\" from es and security nav tree
(#204740)","sha":"6f28942e1ece04051c8e3d031b02ef185e81fc89","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Project:Serverless","Feature:Chrome"],"title":"[Serverless]
Remove \"userAndRoles\" from es and security nav
tree","number":204740,"url":"https://github.com/elastic/kibana/pull/204740","mergeCommit":{"message":"[Serverless]
Remove \"userAndRoles\" from es and security nav tree
(#204740)","sha":"6f28942e1ece04051c8e3d031b02ef185e81fc89"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204740","number":204740,"mergeCommit":{"message":"[Serverless]
Remove \"userAndRoles\" from es and security nav tree
(#204740)","sha":"6f28942e1ece04051c8e3d031b02ef185e81fc89"}}]}]
BACKPORT-->

Co-authored-by: Sébastien Loix <[email protected]>
  • Loading branch information
kibanamachine and sebelga authored Dec 19, 2024
1 parent b3f3940 commit 84e1de0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
4 changes: 0 additions & 4 deletions x-pack/plugins/serverless_search/public/navigation_tree.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,6 @@ export const navigationTree = ({ isAppRegistered }: ApplicationStart): Navigatio
defaultMessage: 'Management',
}),
},
{
id: 'cloudLinkUserAndRoles',
cloudLink: 'userAndRoles',
},
{
id: 'cloudLinkDeployment',
cloudLink: 'deployment',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,7 @@ export const initSideNavigation = async (services: Services) => {
) as GroupDefinition;
if (footerGroup) {
footerGroup.title = PROJECT_SETTINGS_TITLE;
footerGroup.children.push(
{ cloudLink: 'userAndRoles', openInNewTab: true },
{ cloudLink: 'billingAndSub', openInNewTab: true }
);
footerGroup.children.push({ cloudLink: 'billingAndSub', openInNewTab: true });
}
})
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {

await solutionNavigation.sidenav.expectLinkExists({ text: 'Trained models' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Management' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Users and roles' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Performance' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Billing and subscription' });

Expand All @@ -300,7 +299,6 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
'project_settings_project_nav',
'ml:modelManagement',
'management',
'cloudLinkUserAndRoles',
'cloudLinkDeployment',
'cloudLinkBilling',
]);
Expand Down

0 comments on commit 84e1de0

Please sign in to comment.