Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip UA tests when running fwd-compatibility tests #204650

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Skip UA tests when running fwd-compatibility tests #204650

merged 5 commits into from
Dec 19, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Dec 17, 2024 •
edited by kibanamachine
Loading

Summary

Resolves #204520

Reasoning in #204520 (comment)

Checklist

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 17, 2024
@afharo afharo self-assigned this Dec 17, 2024
@afharo afharo requested a review from a team as a code owner December 17, 2024 19:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

rudolf
rudolf approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in 7.x we tended to totally skipped test (for both forward compat and for 7.x), it feels like we need to get a skip tag for explicitly skipping some tests for forward compat, but this seems like a pragmatic solution for now.

@rudolf
Copy link
Contributor

rudolf commented Dec 17, 2024

I was just thinking though, why would upgrade assistant say an upgrade is required if ES is on 9.0. It's not impossible that users end up in a scenario where ES is on 9 and Kibana on 8.18 and they open UA just to be 100% sure there's nothing to be done for Kibana. Just worried ES 9 is complaining about 8.x indices which could cause problems for a major upgrade to 10 which doesn't make sense.

@afharo afharo added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 17, 2024
@afharo
Copy link
Member Author

afharo commented Dec 18, 2024

I was just thinking though, why would upgrade assistant say an upgrade is required if ES is on 9.0. It's not impossible that users end up in a scenario where ES is on 9 and Kibana on 8.18 and they open UA just to be 100% sure there's nothing to be done for Kibana. Just worried ES 9 is complaining about 8.x indices which could cause problems for a major upgrade to 10 which doesn't make sense.

Maybe @Bamieh can provide any insights.

My best guess is that UA is designed to work with a very specific version of ES. Allowing other versions (even the next one that we're trying to upgrade to) could lead to unexpected results.

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / StepDefineRule required fields submits newly added required fields

Metrics [docs]

✅ unchanged

History

cc @afharo

@afharo
Copy link
Member Author

afharo commented Dec 19, 2024

I'll merge it for now because it's causing issues in the forward compatibility tests. We can discuss it later.

@afharo afharo merged commit 6aaa2ea into elastic:main Dec 19, 2024
9 checks passed
@afharo afharo deleted the 204520-fwd-compatibilty-failure branch December 19, 2024 09:55
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12410322712

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 19, 2024
@afharo
Skip UA tests when running fwd-compatibility tests (elastic#204650)
f3dee4b 
## Summary

Resolves elastic#204520

Reasoning in
elastic#204520 (comment)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 6aaa2ea)
@kibanamachine kibanamachine mentioned this pull request Dec 19, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2024
@kibanamachine @afharo
[8.x] Skip UA tests when running fwd-compatibility tests (#204650) (#…
5f539ab 
…204899)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Skip UA tests when running fwd-compatibility tests
(#204650)](#204650)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T09:55:43Z","message":"Skip
UA tests when running fwd-compatibility tests (#204650)\n\n##
Summary\n\nResolves #204520\n\nReasoning
in\nhttps://github.com//issues/204520#issuecomment-2549445238\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"6aaa2eae962927e13eeaa1337e8f5f5ee6b825a5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Skip
UA tests when running fwd-compatibility
tests","number":204650,"url":"https://github.com/elastic/kibana/pull/204650","mergeCommit":{"message":"Skip
UA tests when running fwd-compatibility tests (#204650)\n\n##
Summary\n\nResolves #204520\n\nReasoning
in\nhttps://github.com//issues/204520#issuecomment-2549445238\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"6aaa2eae962927e13eeaa1337e8f5f5ee6b825a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204650","number":204650,"mergeCommit":{"message":"Skip
UA tests when running fwd-compatibility tests (#204650)\n\n##
Summary\n\nResolves #204520\n\nReasoning
in\nhttps://github.com//issues/204520#issuecomment-2549445238\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"6aaa2eae962927e13eeaa1337e8f5f5ee6b825a5"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@afharo @JoseLuisGJ
Skip UA tests when running fwd-compatibility tests (elastic#204650)
0dccaca 
## Summary

Resolves elastic#204520

Reasoning in
elastic#204520 (comment)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf approved these changes

Assignees

@afharo afharo

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
4 participants
@afharo @elasticmachine @rudolf @kibanamachine