Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack API Integration Tests.x-pack/test/api_integration/apis/upgrade_assistant/upgrade_assistant·ts - Upgrade Assistant Upgrade Assistant POST /api/upgrade_assistant/{indexName}/index_settings removes index settings #204520

Closed
kibanamachine opened this issue Dec 17, 2024 · 7 comments · Fixed by #204650
Closed

Failing test: X-Pack API Integration Tests.x-pack/test/api_integration/apis/upgrade_assistant/upgrade_assistant·ts - Upgrade Assistant Upgrade Assistant POST /api/upgrade_assistant/{indexName}/index_settings removes index settings #204520

kibanamachine opened this issue Dec 17, 2024 · 7 comments · Fixed by #204650
Assignees
@afharo
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 17, 2024 •
edited
Loading

A test failed on a tracked branch

Error: expected 200 "OK", got 426 "Upgrade Required"
    at Context.apply (upgrade_assistant.ts:84:12)
    at Object.apply (wrap_function.js:74:30)
----
    at Test._assertStatus (node_modules/supertest/lib/test.js:252:14)
    at /opt/buildkite-agent/builds/bk-agent-prod-gcp-1734413021626276520/elastic/kibana-es-forward-compatibility-testing-9-dot-0/kibana/node_modules/supertest/lib/test.js:308:13
    at Test._assertFunction (node_modules/supertest/lib/test.js:285:13)
    at Test.assert (node_modules/supertest/lib/test.js:164:23)
    at localAssert (node_modules/supertest/lib/test.js:120:14)
    at fn (node_modules/supertest/lib/test.js:125:7)
    at Test.callback (node_modules/superagent/src/node/index.js:899:3)
    at fn (node_modules/superagent/src/node/index.js:1165:18)
    at IncomingMessage.<anonymous> (node_modules/superagent/src/node/parsers/json.js:19:7)
    at IncomingMessage.emit (node:events:531:35)
    at endReadableNT (node:internal/streams/readable:1696:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)

First failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Dec 17, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 17, 2024
@kibanamachine kibanamachine added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Dec 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 17, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@afharo afharo self-assigned this Dec 17, 2024
@afharo
Copy link
Member

afharo commented Dec 17, 2024

This is an error expected when running Kibana against a different version:

kibana/x-pack/plugins/upgrade_assistant/server/lib/es_version_precheck.ts

Lines 84 to 95 in a02c00b

if (!result.allNodesMatch) {
return response.customError({
// 426 means "Upgrade Required" and is used when semver compatibility is not met.
statusCode: 426,
body: {
message: 'There are some nodes running a different version of Elasticsearch',
attributes: {
allNodesUpgraded: result.allNodesUpgraded,
},
},
});
}

I'll see if I can skip the tests when running in forward-compatibility mode

@afharo afharo mentioned this issue Dec 17, 2024
Merged
1 task
@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@afharo afharo closed this as completed in 6aaa2ea Dec 19, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 19, 2024
@afharo
Skip UA tests when running fwd-compatibility tests (elastic#204650)
f3dee4b 
## Summary

Resolves elastic#204520

Reasoning in
elastic#204520 (comment)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 6aaa2ea)
kibanamachine added a commit that referenced this issue Dec 19, 2024
@kibanamachine @afharo
[8.x] Skip UA tests when running fwd-compatibility tests (#204650) (#…
5f539ab 
…204899)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Skip UA tests when running fwd-compatibility tests
(#204650)](#204650)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T09:55:43Z","message":"Skip
UA tests when running fwd-compatibility tests (#204650)\n\n##
Summary\n\nResolves #204520\n\nReasoning
in\nhttps://github.com//issues/204520#issuecomment-2549445238\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"6aaa2eae962927e13eeaa1337e8f5f5ee6b825a5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Skip
UA tests when running fwd-compatibility
tests","number":204650,"url":"https://github.com/elastic/kibana/pull/204650","mergeCommit":{"message":"Skip
UA tests when running fwd-compatibility tests (#204650)\n\n##
Summary\n\nResolves #204520\n\nReasoning
in\nhttps://github.com//issues/204520#issuecomment-2549445238\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"6aaa2eae962927e13eeaa1337e8f5f5ee6b825a5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204650","number":204650,"mergeCommit":{"message":"Skip
UA tests when running fwd-compatibility tests (#204650)\n\n##
Summary\n\nResolves #204520\n\nReasoning
in\nhttps://github.com//issues/204520#issuecomment-2549445238\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"6aaa2eae962927e13eeaa1337e8f5f5ee6b825a5"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
@afharo @JoseLuisGJ
Skip UA tests when running fwd-compatibility tests (elastic#204650)
0dccaca 
## Summary

Resolves elastic#204520

Reasoning in
elastic#204520 (comment)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip UA tests when running fwd-compatibility tests afharo/kibana
3 participants
@afharo @elasticmachine @kibanamachine