Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rules migration] Retry failed translations (#11383) #204619

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Dec 17, 2024

Summary

Internal link to the feature details

These changes add a functionality which allows user to retry failed migration rules.

Other tasks and fixes

  • Integrated MigrationReadyPanel and MigrationProgressPanel to show migration's ready and running states
  • Migration stats pooling issue caused by waiting while there are no pending migrations left. If any other operation triggers startPooling during the waiting it will be ignored and thus latest stats will never come back.

Note

This feature needs siemMigrationsEnabled experimental flag enabled to work.

Testing note

  1. Make sure you have a SIEM migration with failed rules
  2. Open that migration via Security > Rules > SIEM Rules Migrations > {#MIGRATION_WITH_FAILED_RULES}
  3. You should see a Reprocess rules (#) button which triggers failed rules reprocessing

Screen recording

Screen.Recording.2024-12-17.at.17.53.37.mov

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 17, 2024
@e40pud e40pud requested a review from semd December 17, 2024 17:01
@e40pud e40pud self-assigned this Dec 17, 2024
@e40pud e40pud requested a review from a team as a code owner December 17, 2024 17:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 17, 2024 17:22
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @e40pud, good work 💯

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 19, 2024 14:35
@semd semd removed the request for review from a team December 19, 2024 16:25
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6483 6484 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.4MB 21.4MB +5.4KB

History

cc @e40pud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants