Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable editor play button if there are errors in the config #11383

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

ppisljar
Copy link
Member

disable editor play button if there are errors in the configuration - fixes #10416

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.0 labels Apr 24, 2017
@Bargs
Copy link
Contributor

Bargs commented Apr 24, 2017

This fixes the scenario where there's an error in the options tab, but not the error in the Pie chart editor. I'm guessing they're reported differently. If you'd prefer to merge this and create a separate PR to fix the pie chart I think that'd be fine.

screen shot 2017-04-24 at 11 31 06 am

screen shot 2017-04-24 at 11 34 45 am

@ppisljar ppisljar force-pushed the fix/disableVisualizePlay branch from a66e0b4 to 95fc28f Compare April 25, 2017 05:57
@ppisljar ppisljar merged commit 8694acb into elastic:master Apr 26, 2017
ppisljar added a commit to ppisljar/kibana that referenced this pull request Apr 26, 2017
@ppisljar ppisljar mentioned this pull request Apr 26, 2017
@ppisljar
Copy link
Member Author

backport

5.x: 400a3f0
5.4: a09ff30

@ppisljar ppisljar deleted the fix/disableVisualizePlay branch April 26, 2017 10:20
@ppisljar ppisljar restored the fix/disableVisualizePlay branch September 26, 2018 10:06
e40pud added a commit to e40pud/kibana that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vis editor errors aren't disabling the "apply" button
3 participants