Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vis editor errors aren't disabling the "apply" button #10416

Closed
Bargs opened this issue Feb 16, 2017 · 5 comments · Fixed by #11383
Closed

Vis editor errors aren't disabling the "apply" button #10416

Bargs opened this issue Feb 16, 2017 · 5 comments · Fixed by #11383
Assignees
@ppisljar
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v5.4.0

Comments

@Bargs
Copy link
Contributor

Bargs commented Feb 16, 2017

Kibana version: 5.3.0
Elasticsearch version: 5.3.0
Server OS version: Ubuntu 16.04 x64
Browser version: Firefox
Browser OS version: OSX

Original install method (e.g. download page, yum, from source, etc.): Deb

Description of the problem including expected versus actual behavior:

When the editor is in an error state, the apply button should not be clickable.

Steps to reproduce:
(Just one example, I think this applies to any editor error)

  1. Create a Pie chart
  2. Create split slice and split chart buckets
  3. Order the split slice above the split chart
  4. Error text appears in the editor, but apply button is still clickable

screen shot 2017-02-16 at 5 02 00 pm

screen shot 2017-02-16 at 5 03 57 pm
@Bargs Bargs added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience v5.3.0 and removed v5.3.0 labels Feb 16, 2017
@Bargs
Copy link
Contributor Author

Bargs commented Feb 16, 2017

Exists in 5.2 as well, so it's not a 5.3 regression

@ppisljar ppisljar self-assigned this Feb 20, 2017
@tbragin tbragin added the P2 label Feb 28, 2017
@tbragin tbragin added the v5.4.0 label Apr 6, 2017
@ppisljar ppisljar mentioned this issue Apr 24, 2017
Merged
@epixa epixa removed the P2 label Apr 25, 2017
@Bargs
Copy link
Contributor Author

Bargs commented Apr 26, 2017

@ppisljar is there a new issue for the Pie Chart error specifically, since your PR only fixed the error in my second screenshot above?

@ppisljar
Copy link
Member

@Bargs actually i updated this PR so both should be fixed ...

@ppisljar
Copy link
Member

let me know if thats not the case :|

@Bargs
Copy link
Contributor Author

Bargs commented Apr 28, 2017

Oh I didn't notice that, looks good! Thanks @ppisljar

stephmilovic pushed a commit that referenced this issue Oct 7, 2024
@e40pud
[Security Assistant] AI Assistant - Better Solution for OSS models (#…
1ee648d 
…10416) (#194166)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 7, 2024
@e40pud
[Security Assistant] AI Assistant - Better Solution for OSS models (e…
a813812 
…lastic#10416) (elastic#194166)

(cherry picked from commit 1ee648d)
kibanamachine added a commit that referenced this issue Oct 7, 2024
@kibanamachine @e40pud
[8.x] [Security Assistant] AI Assistant - Better Solution for OSS mod…
858e70c 
…els (#10416) (#194166) (#195324)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Assistant] AI Assistant - Better Solution for OSS models
(#10416) (#194166)](#194166)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T21:41:20Z","message":"[Security
Assistant] AI Assistant - Better Solution for OSS models (#10416)
(#194166)","sha":"1ee648d672f0ed5322183d5abd4ebbe4e13f0a93","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:Security
Assistant","Team:Security Generative
AI","v8.16.0","backport:version"],"title":"[Security Assistant] AI
Assistant - Better Solution for OSS models
(#10416)","number":194166,"url":"https://github.com/elastic/kibana/pull/194166","mergeCommit":{"message":"[Security
Assistant] AI Assistant - Better Solution for OSS models (#10416)
(#194166)","sha":"1ee648d672f0ed5322183d5abd4ebbe4e13f0a93"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194166","number":194166,"mergeCommit":{"message":"[Security
Assistant] AI Assistant - Better Solution for OSS models (#10416)
(#194166)","sha":"1ee648d672f0ed5322183d5abd4ebbe4e13f0a93"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisljar ppisljar

Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v5.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disable editor play button if there are errors in the config ppisljar/kibana
4 participants
@epixa @tbragin @Bargs @ppisljar