Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [One Discover] Update log.level indicators color (#202985) #204048

Closed

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## 📓 Summary

Closes elastic#202258

This change updates the colors scale for Discover's `log.level`
indicators to differentiate errors from other levels better.

**N.B. As this relies on some hard-coded values defined
[here](elastic#186273 (comment)),
it is not a definitive version, but a middle step to enhance the scale
in v8.x versions.**
With the introduction of the Borealis theme in v9, a new scale
token-based will replace this.

<img width="934" alt="Screenshot 2024-12-04 at 17 40 32"
src="https://github.com/user-attachments/assets/b3da1300-b39a-4ad0-92c9-fde5dabe91ec">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
(cherry picked from commit c47b509)
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2024

💔 Build Failed

Failed CI Steps

History

cc @tonyghiani

@tonyghiani
Copy link
Contributor

Close as reverted with a mistake, using a variable that only targets v9

@tonyghiani tonyghiani closed this Dec 12, 2024
auto-merge was automatically disabled December 12, 2024 15:32

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants