Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneDiscover] Histogram log.level color indication #186273

Open
kertal opened this issue Jun 17, 2024 · 3 comments
Open

[OneDiscover] Histogram log.level color indication #186273

kertal opened this issue Jun 17, 2024 · 3 comments
Labels
blocked Feature:UnifiedHistogram Issues related to the Unified Histogram plugin Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Jun 17, 2024

📓 Summary

Important

When log.level is selected as a breakdown field, Discover's histogram should be displayed in a mode that is optimized for the consumption of log levels, which means it should be easy to detect log levels of critical, error, warning severity by applying term mapping to colors (tbd) and Breakdown: Filters, here's an example how it looks like in lens, and this is configureable in the Lens embeddable Discover:

Color mapping:

Bildschirmfoto 2024-06-17 um 10 47 08

Breakdown:
Bildschirmfoto 2024-06-17 um 10 55 30

TBD:

  • which colors to use
  • which terms to use for the Filter (e.g. error, err, critical, critical, warn, warning)

✔️ Acceptance criteria

  • Extend UnifiedHistogram so it's Breakdown can be switched to Filters , that can be configured
  • Extend UnifiedHistogram to allow colors by term mapping
  • Make use of this enhancement to show the following terms with matching colors in the histogram when log.level is selected as Breakdown field:
    • critical
    • error
    • warning
    • info
    • debug
    • Other log levels
  • Make use of this enhancement in the Logs Contextual Presentation
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 17, 2024
@kertal kertal added Project:OneDiscover Enrich Discover with contextual awareness Feature:UnifiedFieldList The unified field list component used by Lens & Discover Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 17, 2024
@kertal kertal changed the title [OneDiscover] Histogram log.level optimization [OneDiscover] Histogram log.level color indication Jun 17, 2024
@jughosta jughosta added Feature:UnifiedHistogram Issues related to the Unified Histogram plugin and removed Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Jun 17, 2024
@kertal kertal added the blocked label Sep 18, 2024
@kertal
Copy link
Member Author

kertal commented Sep 18, 2024

Currently blocked by #191988

@gvnmagni
Copy link

Hi all, following a conversation with @LucaWintergerst I tried to explore a couple of options in order to have a quick fix in Amsterdam theme that would solve the problem of having the severity level Error too orange instead of closer to red tones.

I am specifically mentioning Amsterdam as a theme, because for Borealis I would love to be able to create a new Severity Color Palette that could be shared across the whole product, I am currently in the process of mapping all different cases and I will keep you updated about this separately.

For now, the important thing is to fix this issues of red-orange tints.

What I did is simply trying to re-evaluate the scale of reds that we currently use, leaving the orange/yellow tones only for Warnings

I personally suggest Option A, with warmer tones bt I would love to hear from you all what you think.

Current mapping and tokens used with proposals A and B
Image

Proposals for updated palettes
Image

Color codes

Current State (8.16)		|	Option A	|	Option B
Fatal 		#CC5642		|	#BD271E		|	#BD271E	
Emergency 	#CC5642		|	#C73729		|	#C1342C	
Alert 		#DA5E47		|	#D24635		|	#C5423A	
Critical 	#E7664C		|	#DC5640		|	#C94F48	
Error 		#DF9352		|	#E7664C		|	#CD5D56	
Warn 		#D6BF57		|	#D6BF57		|	#D6BF57	
Notice 		#BECFE3		|	#BECFE3		|	#BECFE3	
Info 		#90B0D1		|	#90B0D1		|	#90B0D1	
Debug 		#6092C0		|	#6092C0		|	#6092C0	
Trace 		#D3DAE6		|	#D3DAE6		|	#D3DAE6	
Other 		#D3DAE6		|	#D3DAE6		|	#D3DAE6	

tonyghiani added a commit that referenced this issue Dec 12, 2024
## 📓 Summary

Closes #202258 

This change updates the colors scale for Discover's `log.level`
indicators to differentiate errors from other levels better.

**N.B. As this relies on some hard-coded values defined
[here](#186273 (comment)),
it is not a definitive version, but a middle step to enhance the scale
in v8.x versions.**
With the introduction of the Borealis theme in v9, a new scale
token-based will replace this.

<img width="934" alt="Screenshot 2024-12-04 at 17 40 32"
src="https://github.com/user-attachments/assets/b3da1300-b39a-4ad0-92c9-fde5dabe91ec">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 12, 2024
## 📓 Summary

Closes elastic#202258

This change updates the colors scale for Discover's `log.level`
indicators to differentiate errors from other levels better.

**N.B. As this relies on some hard-coded values defined
[here](elastic#186273 (comment)),
it is not a definitive version, but a middle step to enhance the scale
in v8.x versions.**
With the introduction of the Borealis theme in v9, a new scale
token-based will replace this.

<img width="934" alt="Screenshot 2024-12-04 at 17 40 32"
src="https://github.com/user-attachments/assets/b3da1300-b39a-4ad0-92c9-fde5dabe91ec">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
(cherry picked from commit c47b509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:UnifiedHistogram Issues related to the Unified Histogram plugin Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

4 participants