-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneDiscover] Histogram log.level color indication #186273
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Currently blocked by #191988 |
Hi all, following a conversation with @LucaWintergerst I tried to explore a couple of options in order to have a quick fix in Amsterdam theme that would solve the problem of having the severity level I am specifically mentioning Amsterdam as a theme, because for Borealis I would love to be able to create a new Severity Color Palette that could be shared across the whole product, I am currently in the process of mapping all different cases and I will keep you updated about this separately. For now, the important thing is to fix this issues of red-orange tints. What I did is simply trying to re-evaluate the scale of reds that we currently use, leaving the orange/yellow tones only for I personally suggest Option A, with warmer tones bt I would love to hear from you all what you think. Current mapping and tokens used with proposals A and B Proposals for updated palettes Color codes
|
## 📓 Summary Closes #202258 This change updates the colors scale for Discover's `log.level` indicators to differentiate errors from other levels better. **N.B. As this relies on some hard-coded values defined [here](#186273 (comment)), it is not a definitive version, but a middle step to enhance the scale in v8.x versions.** With the introduction of the Borealis theme in v9, a new scale token-based will replace this. <img width="934" alt="Screenshot 2024-12-04 at 17 40 32" src="https://github.com/user-attachments/assets/b3da1300-b39a-4ad0-92c9-fde5dabe91ec"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]>
## 📓 Summary Closes elastic#202258 This change updates the colors scale for Discover's `log.level` indicators to differentiate errors from other levels better. **N.B. As this relies on some hard-coded values defined [here](elastic#186273 (comment)), it is not a definitive version, but a middle step to enhance the scale in v8.x versions.** With the introduction of the Borealis theme in v9, a new scale token-based will replace this. <img width="934" alt="Screenshot 2024-12-04 at 17 40 32" src="https://github.com/user-attachments/assets/b3da1300-b39a-4ad0-92c9-fde5dabe91ec"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit c47b509)
📓 Summary
Important
When
log.level
is selected as a breakdown field, Discover's histogram should be displayed in a mode that is optimized for the consumption of log levels, which means it should be easy to detect log levels ofcritical
,error
,warning
severity by applying term mapping to colors (tbd) and Breakdown: Filters, here's an example how it looks like in lens, and this is configureable in the Lens embeddable Discover:Color mapping:
Breakdown:
TBD:
✔️ Acceptance criteria
The text was updated successfully, but these errors were encountered: