Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAPS] Updating file upload privileges for maps test user #203992

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[MAPS] Updating file upload privileges for maps test user #203992

merged 2 commits into from
Dec 16, 2024

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Dec 12, 2024 •
edited by kibanamachine
Loading

Clears deprecation warning triggered by maps file upload test.
The role used by the test user needs to now include manage

This should clear the elastic/kibana-presentation deprecation warnings raised here

@jgowdyelastic jgowdyelastic requested a review from nreese December 12, 2024 10:39
@jgowdyelastic jgowdyelastic self-assigned this Dec 12, 2024
@jgowdyelastic jgowdyelastic added v9.0.0 Feature:Maps testing Issues related to tests. v8.18.0 release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Dec 12, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review December 12, 2024 10:41
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner December 12, 2024 10:41
@wayneseymour
Copy link
Member

@jgowdyelastic which test is this for?

@dmlemeshko
Copy link
Member

dmlemeshko commented Dec 12, 2024 •
edited
Loading

which test is this for?

I guess every test that uses geoall_data_writer user and loaded in any x-pack FTR config that
extends x-pack/test/functional/config.base.js and doesn't override security definition

@wayneseymour it seems like the easiest way is to check every config listed in linked issue to not have deprecation warning in logs (assuming the list is full and valid)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #78 / Entity Manager _search API includes source and additional metadata fields

Metrics [docs]

✅ unchanged

cc @jgowdyelastic

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

nreese
nreese approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing

@jgowdyelastic
Copy link
Member Author

@wayneseymour This will fix the deprecation warnings being raised in these two tests:

kibana/x-pack/test/functional/apps/maps/group4/file_upload/geojson.js

Line 47 in 9ab5746

it('should import geojson', async () => {

kibana/x-pack/test/functional/apps/maps/group4/file_upload/shapefile.js

Line 53 in 9ab5746

it('should import shapefile', async () => {

@jgowdyelastic jgowdyelastic merged commit 6f38a4c into elastic:main Dec 16, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12355174531

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 16, 2024
@jgowdyelastic
[MAPS] Updating file upload privileges for maps test user (elastic#20…
fd68213 
…3992)

Clears deprecation warning triggered by maps file upload test.
The role used by the test user needs to now include `manage`

This should clear the `elastic/kibana-presentation` deprecation warnings
raised [here](elastic/kibana-team#1173)

(cherry picked from commit 6f38a4c)
@kibanamachine kibanamachine mentioned this pull request Dec 16, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Dec 16, 2024
Merged
kibanamachine added a commit that referenced this pull request Dec 16, 2024
@kibanamachine @jgowdyelastic
[8.x] [MAPS] Updating file upload privileges for maps test user (#203992
5abc8a3 
) (#204414)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[MAPS] Updating file upload privileges for maps test user
(#203992)](#203992)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T14:52:02Z","message":"[MAPS]
Updating file upload privileges for maps test user (#203992)\n\nClears
deprecation warning triggered by maps file upload test.\r\nThe role used
by the test user needs to now include `manage`\r\n\r\nThis should clear
the `elastic/kibana-presentation` deprecation warnings\r\nraised
[here](https://github.com/elastic/kibana-team/issues/1173)","sha":"6f38a4c46fb9727407bb52df0cf276e73d7342d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Feature:Maps","testing","backport:version","v8.18.0"],"title":"[MAPS]
Updating file upload privileges for maps test
user","number":203992,"url":"https://github.com/elastic/kibana/pull/203992","mergeCommit":{"message":"[MAPS]
Updating file upload privileges for maps test user (#203992)\n\nClears
deprecation warning triggered by maps file upload test.\r\nThe role used
by the test user needs to now include `manage`\r\n\r\nThis should clear
the `elastic/kibana-presentation` deprecation warnings\r\nraised
[here](https://github.com/elastic/kibana-team/issues/1173)","sha":"6f38a4c46fb9727407bb52df0cf276e73d7342d8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203992","number":203992,"mergeCommit":{"message":"[MAPS]
Updating file upload privileges for maps test user (#203992)\n\nClears
deprecation warning triggered by maps file upload test.\r\nThe role used
by the test user needs to now include `manage`\r\n\r\nThis should clear
the `elastic/kibana-presentation` deprecation warnings\r\nraised
[here](https://github.com/elastic/kibana-team/issues/1173)","sha":"6f38a4c46fb9727407bb52df0cf276e73d7342d8"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayneseymour wayneseymour wayneseymour approved these changes

@nreese nreese nreese approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:version Backport to applied version labels Feature:Maps :ml release_note:skip Skip the PR/issue when compiling release notes testing Issues related to tests. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @wayneseymour @dmlemeshko @elasticmachine @kibanamachine @nreese