Sustainable Kibana Architecture: Relocate script v4 #204383
Merged
+120
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
approved these changes
Dec 16, 2024
afharo
approved these changes
Dec 16, 2024
Comment on lines
+20
to
+30
| export const findGithubLogin = async () => { | ||
| const res = await safeExec('gh auth status'); | ||
| // e.g. ✓ Logged in to github.com account gsoldevila (/Users/gsoldevila/.config/gh/hosts.yml) | ||
| const loginLine = res.stdout | ||
| .split('\n') | ||
| .find((line) => line.includes('Logged in')) | ||
| ?.split(/\t| /) | ||
| .filter(Boolean); | ||
|
|
||
| return loginLine?.[loginLine?.findIndex((fragment) => fragment === 'account') + 1]; | ||
| }; |
There was a problem hiding this comment.
this is subject to break in future versions of gh. But OK for now.
Co-authored-by: Alejandro Fernández Haro <[email protected]>
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12356189897 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary