Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Use proper useEuiTheme vars !! #203637

Merged
merged 6 commits into from
Dec 17, 2024
Merged

[Uptime] Use proper useEuiTheme vars !! #203637

merged 6 commits into from
Dec 17, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 10, 2024 •
edited
Loading

Summary

fixes #203340 !!

Overview page
image

image

details page
image

@jasonrhodes
Copy link
Member

@shahzad31 can we make this a more general PR for any updates needed for Borealis in Uptime (similar to this one for SLO), so @patpscal or @kkurstak can review the entire thing at once when it's all been "fixed"? We can use /oblt-deploy to deploy this PR for them to review (I am not 100% sure that will work with Uptime but hopefully yes).

@jasonrhodes
Copy link
Member

/oblt-deploy

@mgadewoll mgadewoll added the backport:skip This commit does not require backporting label Dec 12, 2024
@jasonrhodes
Copy link
Member

@patpscal / @kkurstak let me know if you need help with finding the deployment attached to this PR, it's up and will remain up until 18-Dec (we can re-created it if needed after that)

@jasonrhodes
Copy link
Member

Actually, @shahzad31 I am not sure how we turn Uptime on these days so it may not be possible to have that running in this PR deployment, we may need to adjust how we do the final check with design team for Uptime.

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #105 / Entity Manager _count API is resilient to no valid sources

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 591 590 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 467.8KB 466.9KB -920.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uptime 22.9KB 22.9KB -54.0B

History

@shahzad31 shahzad31 marked this pull request as ready for review December 16, 2024 15:03
@shahzad31 shahzad31 requested a review from a team as a code owner December 16, 2024 15:03
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Dec 16, 2024
kdelemme
kdelemme approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, working as expected. LGTM

@shahzad31 shahzad31 merged commit 78f1d17 into elastic:main Dec 17, 2024
10 checks passed
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@shahzad31 @kibanamachine @JoseLuisGJ
[Uptime] Use proper useEuiTheme vars !! (elastic#203637)
9dadb39 
## Summary

fixes elastic#203340 !!


Overview page 
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/80ab4c2a-9999-4a83-b355-130ca7dedc01"
/>

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/dcc5e564-7047-4c9c-aba7-1a126ea2f9b9"
/>

details page 
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/d7e414d3-e3f3-4b7b-aab0-799d099b63c2"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@shahzad31 @kibanamachine @benakansara
[Uptime] Use proper useEuiTheme vars !! (elastic#203637)
c7410ec 
## Summary

fixes elastic#203340 !!


Overview page 
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/80ab4c2a-9999-4a83-b355-130ca7dedc01"
/>

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/dcc5e564-7047-4c9c-aba7-1a126ea2f9b9"
/>

details page 
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/d7e414d3-e3f3-4b7b-aab0-799d099b63c2"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Audit new EUI Borealis theme
7 participants
@shahzad31 @jasonrhodes @elasticmachine @kdelemme @JasonStoltz @kibanamachine @mgadewoll