Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Audit new EUI Borealis theme #203340

Closed
9 tasks
jasonrhodes opened this issue Dec 6, 2024 · 3 comments · Fixed by #203637
Closed
9 tasks

[Uptime] Audit new EUI Borealis theme #203340

jasonrhodes opened this issue Dec 6, 2024 · 3 comments · Fixed by #203637
Assignees
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@jasonrhodes
Copy link
Member

Full instructions for how to do this audit can be found #199715, but the AC checklist has been copied here, with links to the relevant sections of that issue.

Acceptance criteria for the Uptime plugin

Important

Things marked as Required must be completed. Everything else we would really like teams to give their best effort to resolve, but are ultimately non-blocking.

Important details on each of these steps is noted in the main issue which has been linked to via each step's "details" link, but these "details" links reference HTML anchors in the linked issue and may require reloading the page in order to have the browser navigate correctly to the anchor position.

  • (Required) All usages of "success" colors have been updated to "accentSecondary" and "textAccentSecondary" as needed (details).
  • (Required) All usages of "successText" colors have been updated to "textAccentSecondary" as needed (details).
  • (Required) All references to renamed tokens have been updated to use the new token name. (details)
  • (Required) All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa. (details)
  • (Required) @kkurstak or @patpscal has reviewed the UI with the new changes and is ready to ship.
  • All usages of vis colors for non-visulalization usage have been removed in favor of other EUI color tokens, where possible. (details)
  • All "Custom colors" have been replaced with EUI color tokens. (details)
  • All usages of color functions have been removed in favor of color tokens, where possible. (details)
  • All usages of JSON tokens have been removed in favor of color tokens, where possible. (details)
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 6, 2024
@jasonrhodes jasonrhodes added the Team:obs-ux-management Observability Management User Experience Team label Dec 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 6, 2024
@shahzad31 shahzad31 self-assigned this Dec 9, 2024
@shahzad31
Copy link
Contributor

putting back to read state, it seems like pre-mature to test it until common problems can be addressed.

@shahzad31 shahzad31 assigned shahzad31 and unassigned shahzad31 Dec 9, 2024
@shahzad31
Copy link
Contributor

back to work

shahzad31 added a commit that referenced this issue Dec 17, 2024
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
benakansara pushed a commit to benakansara/kibana that referenced this issue Jan 2, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants