Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16] [APM] Time spent by span type chart rendering problems (#202755) #203075

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[8.16] [APM] Time spent by span type chart rendering problems (#202755) #203075

merged 3 commits into from
Dec 5, 2024

Conversation

miloszmarcinkowski
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

@miloszmarcinkowski
[APM] Time spent by span type chart rendering problems (elastic#202755
14f55a0 
)

Closes elastic#202343

## Summary

This PR solves the following issues in `Time spent by span type` chart:
- limits percentages between 0% and 100% (converts negative values to
0%),

before:
<img width="1134" alt="Screenshot 2024-12-04 at 15 28 18"
src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3">
after:
<img width="1135" alt="Screenshot 2024-12-04 at 15 30 25"
src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734">

---

- rounds percentage to 8 decimal points to prevent scientific notation
in charts (poor readability)

before:
<img width="1132" alt="Screenshot 2024-12-04 at 14 36 54"
src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369">
after:
<img width="1132" alt="Screenshot 2024-12-04 at 14 35 39"
src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892">

(cherry picked from commit ab9de64)
@miloszmarcinkowski miloszmarcinkowski enabled auto-merge (squash) December 5, 2024 10:57
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Dec 5, 2024
@miloszmarcinkowski miloszmarcinkowski mentioned this pull request Dec 5, 2024
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

cauemarcondes
cauemarcondes approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 5, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 910b87e
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203075-910b87e0490c

Metrics [docs]

✅ unchanged

History

@miloszmarcinkowski miloszmarcinkowski merged commit 7d08846 into elastic:8.16 Dec 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miloszmarcinkowski @elasticmachine @cauemarcondes