[APM] Time spent by span type chart rendering problems
#202755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloszmarcinkowski
added
release_note:skip
miloszmarcinkowski
force-pushed
the
202343-apm-time-spent-by-span-type-chart-rendering-problem
branch
from
9a8d33e to
be2ccac
Compare
💚 Build Succeeded
Metrics [docs]
History
|
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12177539846 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892"> (cherry picked from commit ab9de64)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Dec 5, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
miloszmarcinkowski
added a commit
to miloszmarcinkowski/kibana
that referenced
this pull request
Dec 5, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892"> (cherry picked from commit ab9de64)
miloszmarcinkowski
added a commit
to miloszmarcinkowski/kibana
that referenced
this pull request
Dec 5, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892"> (cherry picked from commit ab9de64)
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
…ems (#202755) (#203066) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] `Time spent by span type` chart rendering problems (#202755)](#202755) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T10:08:05Z","message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM] `Time spent by span type` chart rendering problems","number":202755,"url":"https://github.com/elastic/kibana/pull/202755","mergeCommit":{"message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202755","number":202755,"mergeCommit":{"message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <[email protected]>
miloszmarcinkowski
added a commit
that referenced
this pull request
Dec 5, 2024
) (#203075) # Backport This will backport the following commits from `main` to `8.16`: - [[APM] `Time spent by span type` chart rendering problems (#202755)](#202755) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T10:08:05Z","message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"number":202755,"url":"https://github.com/elastic/kibana/pull/202755","mergeCommit":{"message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202755","number":202755,"mergeCommit":{"message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8"}},{"url":"https://github.com/elastic/kibana/pull/203066","number":203066,"branch":"8.x","state":"OPEN"}]}] BACKPORT-->
miloszmarcinkowski
added a commit
that referenced
this pull request
Dec 5, 2024
) (#203074) # Backport This will backport the following commits from `main` to `8.17`: - [[APM] `Time spent by span type` chart rendering problems (#202755)](#202755) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T10:08:05Z","message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"number":202755,"url":"https://github.com/elastic/kibana/pull/202755","mergeCommit":{"message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202755","number":202755,"mergeCommit":{"message":"[APM] `Time spent by span type` chart rendering problems (#202755)\n\nCloses #202343\r\n\r\n## Summary\r\n\r\nThis PR solves the following issues in `Time spent by span type` chart:\r\n- limits percentages between 0% and 100% (converts negative values to\r\n0%),\r\n\r\nbefore: \r\n<img width=\"1134\" alt=\"Screenshot 2024-12-04 at 15 28 18\"\r\nsrc=\"https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3\">\r\nafter:\r\n<img width=\"1135\" alt=\"Screenshot 2024-12-04 at 15 30 25\"\r\nsrc=\"https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734\">\r\n\r\n---\r\n\r\n- rounds percentage to 8 decimal points to prevent scientific notation\r\nin charts (poor readability)\r\n\r\nbefore: \r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 36 54\"\r\nsrc=\"https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369\">\r\nafter:\r\n<img width=\"1132\" alt=\"Screenshot 2024-12-04 at 14 35 39\"\r\nsrc=\"https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892\">","sha":"ab9de649fe32b22b4f847d190be73fbf229a1ac8"}},{"url":"https://github.com/elastic/kibana/pull/203066","number":203066,"branch":"8.x","state":"OPEN"}]}] BACKPORT-->
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892">
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892">
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892">
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892">
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892">
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
) Closes elastic#202343 ## Summary This PR solves the following issues in `Time spent by span type` chart: - limits percentages between 0% and 100% (converts negative values to 0%), before: <img width="1134" alt="Screenshot 2024-12-04 at 15 28 18" src="https://github.com/user-attachments/assets/73285e87-3aef-4b2d-8e2a-7e3ec87680f3"> after: <img width="1135" alt="Screenshot 2024-12-04 at 15 30 25" src="https://github.com/user-attachments/assets/ae25cb85-d31a-490a-96c7-d4475952c734"> --- - rounds percentage to 8 decimal points to prevent scientific notation in charts (poor readability) before: <img width="1132" alt="Screenshot 2024-12-04 at 14 36 54" src="https://github.com/user-attachments/assets/528cda4b-ae84-4dbd-9d3f-88896e63a369"> after: <img width="1132" alt="Screenshot 2024-12-04 at 14 35 39" src="https://github.com/user-attachments/assets/9a0bdce9-6d66-4aaf-a131-18644eab1892">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202343
Summary
This PR solves the following issues in
Time spent by span typechart:before:
after:
before:
after: